From: "Ouyang, Changchun" <changchun.ouyang@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd
Date: Tue, 21 Oct 2014 08:28:50 +0000 [thread overview]
Message-ID: <F52918179C57134FAEC9EA62FA2F962511878A4E@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8972262DE86@IRSMSX108.ger.corp.intel.com>
Hi Pablo
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Tuesday, October 21, 2014 4:19 PM
> To: Thomas Monjalon; Ouyang, Changchun
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd
>
> Hi Thomas,
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > Sent: Tuesday, October 21, 2014 9:04 AM
> > To: Ouyang, Changchun
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd
> >
> > 2014-10-21 14:59, Ouyang Changchun:
> > > Fix the compilation issue in vector PMD when macro RTE_MBUF_REFCNT
> > > is
> > disabled.
> > >
> > > Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> >
> > Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> >
> > Applied
>
> I was checking this patch right now, and I come across a second compilation
> issue, because rte_mbuf_refcnt_update and rte_pktmbuf_attach are not
> declared, and Bond PMD and IP fragmentation libraries use those functions.
>
> I guess that it is late to NACK this :P, but we require a second patch to fix
> completely this issue.
As it fixes the compilation issue in vpmd, so no reason to NACK it, :-)
In my config, both BOND and IP fragment is disabled. So I don't come across your issues.
Yes, agree with you, we need another patch to fix compilation issue in other both places.
next prev parent reply other threads:[~2014-10-21 8:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 6:59 Ouyang Changchun
2014-10-21 8:04 ` Thomas Monjalon
2014-10-21 8:19 ` De Lara Guarch, Pablo
2014-10-21 8:28 ` Ouyang, Changchun [this message]
2014-10-21 8:36 ` Thomas Monjalon
2014-10-21 13:45 ` Doherty, Declan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F52918179C57134FAEC9EA62FA2F962511878A4E@shsmsx102.ccr.corp.intel.com \
--to=changchun.ouyang@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).