From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 013E47E7A for ; Tue, 21 Oct 2014 10:23:53 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 21 Oct 2014 01:32:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,760,1406617200"; d="scan'208";a="608569294" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by fmsmga001.fm.intel.com with ESMTP; 21 Oct 2014 01:32:06 -0700 Received: from pgsmsx102.gar.corp.intel.com (10.221.44.80) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 21 Oct 2014 16:28:51 +0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by PGSMSX102.gar.corp.intel.com (10.221.44.80) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 21 Oct 2014 16:28:50 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.156]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.202]) with mapi id 14.03.0195.001; Tue, 21 Oct 2014 16:28:50 +0800 From: "Ouyang, Changchun" To: "De Lara Guarch, Pablo" , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd Thread-Index: AQHP7PyXlaf/LVfruUKMfGQw2xZ2ZJw5qxeAgAAEMgCAAIcCsA== Date: Tue, 21 Oct 2014 08:28:50 +0000 Message-ID: References: <1413874756-18669-1-git-send-email-changchun.ouyang@intel.com> <1430189.igvNPv7CnC@xps13> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Oct 2014 08:23:54 -0000 Hi Pablo > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Tuesday, October 21, 2014 4:19 PM > To: Thomas Monjalon; Ouyang, Changchun > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd >=20 > Hi Thomas, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Tuesday, October 21, 2014 9:04 AM > > To: Ouyang, Changchun > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd > > > > 2014-10-21 14:59, Ouyang Changchun: > > > Fix the compilation issue in vector PMD when macro RTE_MBUF_REFCNT > > > is > > disabled. > > > > > > Signed-off-by: Changchun Ouyang > > > > Acked-by: Thomas Monjalon > > > > Applied >=20 > I was checking this patch right now, and I come across a second compilati= on > issue, because rte_mbuf_refcnt_update and rte_pktmbuf_attach are not > declared, and Bond PMD and IP fragmentation libraries use those functions= . >=20 > I guess that it is late to NACK this :P, but we require a second patch to= fix > completely this issue. As it fixes the compilation issue in vpmd, so no reason to NACK it, :-) In my config, both BOND and IP fragment is disabled. So I don't come across= your issues. Yes, agree with you, we need another patch to fix compilation issue in othe= r both places.