From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 8BCC47F49 for ; Sat, 8 Nov 2014 05:44:20 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 07 Nov 2014 20:53:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="413384387" Received: from kmsmsx152.gar.corp.intel.com ([172.21.73.87]) by FMSMGA003.fm.intel.com with ESMTP; 07 Nov 2014 20:45:12 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by KMSMSX152.gar.corp.intel.com (172.21.73.87) with Microsoft SMTP Server (TLS) id 14.3.195.1; Sat, 8 Nov 2014 10:13:49 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.156]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.174]) with mapi id 14.03.0195.001; Sat, 8 Nov 2014 10:13:48 +0800 From: "Ouyang, Changchun" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v3 1/5] ethdev: add vmdq rx mode Thread-Index: AQHP9MpDg10+S+6rukOJ84H1gC4ufpxTIveAgALmfMA= Date: Sat, 8 Nov 2014 02:13:48 +0000 Message-ID: References: <1414381533-30370-1-git-send-email-changchun.ouyang@intel.com> <1414732757-7241-1-git-send-email-changchun.ouyang@intel.com> <1414732757-7241-2-git-send-email-changchun.ouyang@intel.com> <13741309.jhnrGuo18k@xps13> In-Reply-To: <13741309.jhnrGuo18k@xps13> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add vmdq rx mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Nov 2014 04:44:21 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, November 6, 2014 9:56 PM > To: Ouyang, Changchun > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add vmdq rx mode >=20 > 2014-10-31 13:19, Ouyang Changchun: > > --- a/lib/librte_ether/rte_ethdev.h > > +++ b/lib/librte_ether/rte_ethdev.h > > @@ -577,6 +577,7 @@ struct rte_eth_vmdq_rx_conf { > > uint8_t default_pool; /**< The default pool, if applicable */ > > uint8_t enable_loop_back; /**< Enable VT loop back */ > > uint8_t nb_pool_maps; /**< We can have up to 64 filters/mappings > */ > > + uint32_t rx_mode; /**< RX mode for vmdq */ >=20 > You are adding the field rx_mode in struct rte_eth_vmdq_rx_conf. > So the comment "RX mode for vmdq" is not really informative :) It would b= e > more interesting to explain which kind of value this field must contain. > Something like "flags from ETH_VMDQ_ACCEPT_*". >=20 Thanks for your comments, I will update it. Changchun