From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 26D3F7F70 for ; Wed, 12 Nov 2014 01:20:36 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 11 Nov 2014 16:30:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,362,1413270000"; d="scan'208";a="620863266" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by fmsmga001.fm.intel.com with ESMTP; 11 Nov 2014 16:29:45 -0800 Received: from pgsmsx107.gar.corp.intel.com (10.221.44.105) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 12 Nov 2014 08:29:44 +0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by PGSMSX107.gar.corp.intel.com (10.221.44.105) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 12 Nov 2014 08:29:44 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.136]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.241]) with mapi id 14.03.0195.001; Wed, 12 Nov 2014 08:29:43 +0800 From: "Ouyang, Changchun" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v4 0/5] Support virtio multicast feature Thread-Index: AQHP+wwnRlR/agcHXUeufe9mAcjWgJxbjuWAgACY15A= Date: Wed, 12 Nov 2014 00:29:42 +0000 Message-ID: References: <1414732757-7241-1-git-send-email-changchun.ouyang@intel.com> <1415420776-4821-1-git-send-email-changchun.ouyang@intel.com> <20823298.IzMeYNyBN7@xps13> In-Reply-To: <20823298.IzMeYNyBN7@xps13> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v4 0/5] Support virtio multicast feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Nov 2014 00:20:37 -0000 Hi Thomas, Thanks very much for applying this patch! > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, November 12, 2014 7:17 AM > To: Ouyang, Changchun > Cc: dev@dpdk.org; Xie, Huawei > Subject: Re: [dpdk-dev] [PATCH v4 0/5] Support virtio multicast feature >=20 > > -V1 change: > > This patch series support multicast feature in virtio and vhost. > > The vhost backend enables the promiscuous mode and config > > ETH_VMDQ_ACCEPT_BROADCAST and ETH_VMDQ_ACCEPT_MULTICAST in > VMDQ offload register to receive the multicast and broadcast packets. > > The virtio frontend provides the functionality of enabling and > > disabling the multicast and promiscuous mode. > > > > -V2 change: > > Rework the patch basing on new vhost library and new vhost application. > > > > -V3 change: > > Rework the patch for comments, split commits. > > > > -V4 change: > > Rework for refining code comment and patch titles, fatorizing codes, an= d > resolving conflicts. > > > > Changchun Ouyang (5): > > ethdev: Add vmdq rx mode > > igb: Config VM offload register > > ixgbe: Configure Rx mode for VMDQ > > virtio: Support promiscuous and allmulticast > > vhost: Enable promisc mode and multicast >=20 > I reviewed only the first 3 commits. > The virtio and vhost commits seem to have been reviewed by Huawei. > Next times, a clear acked-by would be preferable. > Please note that this is the role of developpers to request reviews when > needed. Reviews are not always spontaneous :) >=20 Yes I have asked some guys more than 3 times to review and ack this patch, Just because each guy has tightly schedule on their own patch rework, doc w= riting, next feature planning, etc, So the patch-acking delays.. Thanks again and regards, Changchun