From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <changchun.ouyang@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id EF8AE959
 for <dev@dpdk.org>; Mon, 15 Dec 2014 04:25:20 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga102.jf.intel.com with ESMTP; 14 Dec 2014 19:23:47 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.04,691,1406617200"; d="scan'208";a="498705315"
Received: from kmsmsx151.gar.corp.intel.com ([172.21.73.86])
 by orsmga003.jf.intel.com with ESMTP; 14 Dec 2014 19:21:13 -0800
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
 KMSMSX151.gar.corp.intel.com (172.21.73.86) with Microsoft SMTP Server (TLS)
 id 14.3.195.1; Mon, 15 Dec 2014 11:25:18 +0800
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.216]) by
 SHSMSX101.ccr.corp.intel.com ([169.254.1.110]) with mapi id 14.03.0195.001;
 Mon, 15 Dec 2014 11:25:16 +0800
From: "Ouyang, Changchun" <changchun.ouyang@intel.com>
To: "Fu, Weiyi (NSN - CN/Hangzhou)" <weiyi.fu@nsn.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Thread-Topic: [dpdk-dev]  In DPDK 1.7.1, the link status of the interface
 using virtio driver is always down.
Thread-Index: AdAVGAyqYy44KGUjQTy/NjxEYje2g5yKEnVAgAAxdTCAAFnNAIAAlTsQgATGo1Ccif3mIA==
Date: Mon, 15 Dec 2014 03:25:15 +0000
Message-ID: <F52918179C57134FAEC9EA62FA2F962511946BBE@shsmsx102.ccr.corp.intel.com>
References: <2680B515A539A446ACBEC0EBBDEC3DF80E938312@SGSIMBX001.nsn-intra.net>
 <F52918179C57134FAEC9EA62FA2F9625119456D4@shsmsx102.ccr.corp.intel.com>
 <2680B515A539A446ACBEC0EBBDEC3DF80E938465@SGSIMBX001.nsn-intra.net>
 <F52918179C57134FAEC9EA62FA2F962511945B8E@shsmsx102.ccr.corp.intel.com>
 <2680B515A539A446ACBEC0EBBDEC3DF80E9388D2@SGSIMBX001.nsn-intra.net>
In-Reply-To: <2680B515A539A446ACBEC0EBBDEC3DF80E9388D2@SGSIMBX001.nsn-intra.net>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] In DPDK 1.7.1,
 the link status of the interface using virtio driver is always down.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Dec 2014 03:25:21 -0000

Hi Weiyi,
Thanks for updating.

> -----Original Message-----
> From: Fu, Weiyi (NSN - CN/Hangzhou) [mailto:weiyi.fu@nsn.com]
> Sent: Monday, December 15, 2014 10:56 AM
> To: Fu, Weiyi (NSN - CN/Hangzhou); Ouyang, Changchun; dev@dpdk.org
> Cc: mmvijay@gmail.com
> Subject: RE: [dpdk-dev] In DPDK 1.7.1, the link status of the interface u=
sing
> virtio driver is always down.
>=20
> Hi,
> With follow changes, the link is UP and interface can receive and send tr=
affic.
> Thanks a lot:)
>=20
> diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c
> b/lib/librte_pmd_virtio/virtio_ethdev.c
> index 3344ffb..43d1c19 100644
> --- a/lib/librte_pmd_virtio/virtio_ethdev.c
> +++ b/lib/librte_pmd_virtio/virtio_ethdev.c
> @@ -784,6 +784,7 @@ eth_virtio_dev_init(__rte_unused struct eth_driver
> *eth_drv,
>         }
>  #endif
>         hw->use_msix =3D virtio_has_msix(&pci_dev->addr);
> +       hw->use_msix  =3D 1;

Use constant is not a good fix, maybe you can have a solid fix for this,
Check how it can find the msix information on your environment, and then
You may change some codes inside function virtio_has_msix to let it also
Work in your environment even without " hw->use_msix  =3D 1".

Thanks
Changchun