From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id F086519F5 for ; Wed, 24 Dec 2014 04:50:17 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 23 Dec 2014 19:50:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="432828373" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by FMSMGA003.fm.intel.com with ESMTP; 23 Dec 2014 19:38:43 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 24 Dec 2014 11:50:15 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.216]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.67]) with mapi id 14.03.0195.001; Wed, 24 Dec 2014 11:50:14 +0800 From: "Ouyang, Changchun" To: "Zhang, Helin" Thread-Topic: [dpdk-dev] [PATCH v2 1/6] ixgbe: Code cleanup Thread-Index: AQHQHyVOn4jB/kSoNkO30lIr2iosdZydiU8AgACJFaD//4AXAIAAhwoQ Date: Wed, 24 Dec 2014 03:50:13 +0000 Message-ID: References: <1418612225-6095-1-git-send-email-changchun.ouyang@intel.com> <1419389808-9559-1-git-send-email-changchun.ouyang@intel.com> <1419389808-9559-2-git-send-email-changchun.ouyang@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 1/6] ixgbe: Code cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Dec 2014 03:50:18 -0000 Hi Helin, > -----Original Message----- > From: Zhang, Helin > Sent: Wednesday, December 24, 2014 11:41 AM > To: Ouyang, Changchun > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2 1/6] ixgbe: Code cleanup >=20 > Hi Changchun >=20 > > -----Original Message----- > > From: Ouyang, Changchun > > Sent: Wednesday, December 24, 2014 11:22 AM > > To: Zhang, Helin; dev@dpdk.org > > Cc: Ouyang, Changchun > > Subject: RE: [dpdk-dev] [PATCH v2 1/6] ixgbe: Code cleanup > > > > Hi Helin, > > > > > -----Original Message----- > > > From: Zhang, Helin > > > Sent: Wednesday, December 24, 2014 11:08 AM > > > To: Ouyang, Changchun; dev@dpdk.org > > > Subject: RE: [dpdk-dev] [PATCH v2 1/6] ixgbe: Code cleanup > > > > > > Is header split really supported in ixgbe? I guess not. If not, this > > > code changes are not needed at all. > > > > > > > I don't try to modify any logic here, as you know vf rss don't have > > nothing to do with header split. > But you modified code for header split. Have you validated it? >=20 > > You mean " guess not ", can you 'make sure of it' rather than 'guess' > > if you want to remove those codes? > I did not see anywhere can enable ixgbe header split. It is your turn to = make > sure if your code changes are needed and correct. I don't want to remove > any code, just want to know if your code have been validated for header s= plit. Yes, I make sure the code change is correct, and already validate the code = change on my platform, besides that,=20 we also have validation team to do further validation. any other concern th= en? Thanks Changchun