From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id C3FD65938 for ; Mon, 5 Jan 2015 03:38:29 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP; 04 Jan 2015 18:35:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,696,1413270000"; d="scan'208";a="656744875" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by fmsmga002.fm.intel.com with ESMTP; 04 Jan 2015 18:38:13 -0800 Received: from kmsmsx154.gar.corp.intel.com (172.21.73.14) by PGSMSX107.gar.corp.intel.com (10.221.44.105) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 5 Jan 2015 10:38:12 +0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by KMSMSX154.gar.corp.intel.com (172.21.73.14) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 5 Jan 2015 10:38:12 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.216]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.110]) with mapi id 14.03.0195.001; Mon, 5 Jan 2015 10:38:11 +0800 From: "Ouyang, Changchun" To: Vlad Zolotarov , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode Thread-Index: AQHQJ+7Jp8U/K7/F20SklzBchptxdpyvILoAgACJDKD//4b2gIABngWw Date: Mon, 5 Jan 2015 02:38:10 +0000 Message-ID: References: <1419398584-19520-1-git-send-email-changchun.ouyang@intel.com> <1420355937-18484-1-git-send-email-changchun.ouyang@intel.com> <1420355937-18484-7-git-send-email-changchun.ouyang@intel.com> <54A8FE9A.60606@cloudius-systems.com> <54A90C07.5090507@cloudius-systems.com> In-Reply-To: <54A90C07.5090507@cloudius-systems.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jan 2015 02:38:30 -0000 > -----Original Message----- > From: Vlad Zolotarov [mailto:vladz@cloudius-systems.com] > Sent: Sunday, January 4, 2015 5:47 PM > To: Ouyang, Changchun; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode >=20 >=20 > On 01/04/15 11:01, Ouyang, Changchun wrote: > >> -----Original Message----- > >> From: Vlad Zolotarov [mailto:vladz@cloudius-systems.com] > >> Sent: Sunday, January 4, 2015 4:50 PM > >> To: Ouyang, Changchun; dev@dpdk.org > >> Subject: Re: [dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode > >> > >> > >> On 01/04/15 09:18, Ouyang Changchun wrote: > >>> Set VMDq RSS mode if it has VF(VF number is more than 1) and has RSS > >> information. > >>> Signed-off-by: Changchun Ouyang > >>> --- > >>> app/test-pmd/testpmd.c | 10 ++++++++++ > >>> 1 file changed, 10 insertions(+) > >>> > >>> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > >>> 8c69756..6230f8b 100644 > >>> --- a/app/test-pmd/testpmd.c > >>> +++ b/app/test-pmd/testpmd.c > >>> @@ -1708,6 +1708,16 @@ init_port_config(void) > >>> port->dev_conf.rxmode.mq_mode =3D > >> ETH_MQ_RX_NONE; > >>> } > >>> > >>> + if (port->dev_info.max_vfs !=3D 0) { > >>> + if (port->dev_conf.rx_adv_conf.rss_conf.rss_hf !=3D 0) > >>> + port->dev_conf.rxmode.mq_mode =3D > >>> + ETH_MQ_RX_VMDQ_RSS; > >>> + else { > >>> + port->dev_conf.rxmode.mq_mode =3D > >> ETH_MQ_RX_NONE; > >>> + port->dev_conf.txmode.mq_mode =3D > >> ETH_MQ_TX_NONE; > >> > >> And what about the txmode.mq_mode when RSS is available (the :if" > clause)? > > I think we can keep its original value for txmode.mq_mode, so don't > change its value. How do you think of it? >=20 > I agree that not changing a Tx mq_mode in both cases would be better. In the else clause, set txmode.mq_mode as ETH_MQ_TX_NONE explicitly to make= sure it is neither ETH_MQ_TX_DCB, ETH_MQ_TX_VMDQ_DCB, nor ETH_MQ_TX_VMDQ_ONLY. > > Thanks > > Changchun > > > >