From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 78EC3569A for ; Tue, 6 Jan 2015 02:00:26 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 05 Jan 2015 17:00:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,702,1413270000"; d="scan'208";a="657261030" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by fmsmga002.fm.intel.com with ESMTP; 05 Jan 2015 17:00:23 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by PGSMSX107.gar.corp.intel.com (10.221.44.105) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 6 Jan 2015 09:00:23 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.216]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.110]) with mapi id 14.03.0195.001; Tue, 6 Jan 2015 09:00:21 +0800 From: "Ouyang, Changchun" To: "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH v3 5/6] ixgbe: Config VF RSS Thread-Index: AQHQHznC9fbr7m6mLEynsGIYrmMT5JyeB1MAgAGQNdCAAC7zAIABUPNQgA/I8YCAAXldkA== Date: Tue, 6 Jan 2015 01:00:21 +0000 Message-ID: References: <1419389808-9559-1-git-send-email-changchun.ouyang@intel.com> <1419398584-19520-1-git-send-email-changchun.ouyang@intel.com> <1419398584-19520-6-git-send-email-changchun.ouyang@intel.com> <549A97F6.30901@cloudius-systems.com> <549C0F10.8050402@cloudius-systems.com> <20150105102920.GA13152@bricha3-MOBL3> In-Reply-To: <20150105102920.GA13152@bricha3-MOBL3> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 5/6] ixgbe: Config VF RSS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jan 2015 01:00:27 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Monday, January 5, 2015 6:29 PM > To: Ouyang, Changchun > Cc: Vlad Zolotarov; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 5/6] ixgbe: Config VF RSS >=20 > On Fri, Dec 26, 2014 at 01:52:25AM +0000, Ouyang, Changchun wrote: > > > > > > > -----Original Message----- > > > From: Vlad Zolotarov [mailto:vladz@cloudius-systems.com] > > > Sent: Thursday, December 25, 2014 9:20 PM > > > To: Ouyang, Changchun; dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH v3 5/6] ixgbe: Config VF RSS > > > > > > > > Like I said before, trying to guess what user wants is a way to > > > making a code that is very hard to use and to maintain. Pls., just > > > return an error and let the user code deal with it the way he/she > > > really wants and not the way u *think* he/she wants. > > > > > I didn't disagree on this, either :-) > > If you have strong reason for this way and more guys agree with it, I > > will modify it probably in v4. > > > > > +1 on returning error. It does in v4 patch.