From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 7572758DD for ; Fri, 9 Jan 2015 06:21:32 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 08 Jan 2015 21:21:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,728,1413270000"; d="scan'208";a="648528716" Received: from kmsmsx151.gar.corp.intel.com ([172.21.73.86]) by fmsmga001.fm.intel.com with ESMTP; 08 Jan 2015 21:21:29 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by KMSMSX151.gar.corp.intel.com (172.21.73.86) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 9 Jan 2015 13:21:29 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.216]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.92]) with mapi id 14.03.0195.001; Fri, 9 Jan 2015 13:21:27 +0800 From: "Ouyang, Changchun" To: "Xie, Huawei" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 3/5] vhost: enable promisc mode and config VMDQ offload register for multicast feature Thread-Index: AQHP8ZiWaTe6iUB4qUqeWNzwnR/mzZy2cCoggAFEHdA= Date: Fri, 9 Jan 2015 05:21:27 +0000 Message-ID: References: <1408932572-10343-1-git-send-email-changchun.ouyang@intel.com> <1414381533-30370-1-git-send-email-changchun.ouyang@intel.com> <1414381533-30370-4-git-send-email-changchun.ouyang@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/5] vhost: enable promisc mode and config VMDQ offload register for multicast feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jan 2015 05:21:32 -0000 Hi Huawei, > -----Original Message----- > From: Xie, Huawei > Sent: Thursday, January 8, 2015 6:08 PM > To: Ouyang, Changchun; dev@dpdk.org > Cc: Tetsuya Mukawa > Subject: RE: [dpdk-dev] [PATCH v2 3/5] vhost: enable promisc mode and > config VMDQ offload register for multicast feature >=20 > > diff --git a/lib/librte_vhost/virtio-net.c > > b/lib/librte_vhost/virtio-net.c index 27ba175..744156c 100644 > > --- a/lib/librte_vhost/virtio-net.c > > +++ b/lib/librte_vhost/virtio-net.c > > @@ -68,7 +68,9 @@ static struct virtio_net_device_ops const *notify_ops= ; > > static struct virtio_net_config_ll *ll_root; > > > > /* Features supported by this application. RX merge buffers are > > enabled by default. */ -#define VHOST_SUPPORTED_FEATURES (1ULL << > > VIRTIO_NET_F_MRG_RXBUF) > > +#define VHOST_SUPPORTED_FEATURES ((1ULL << > VIRTIO_NET_F_MRG_RXBUF) > > | \ > > + (1ULL << VIRTIO_NET_F_CTRL_RX)) > > + > CTRL_RX is dependent on CTRL_VQ. > CTRL_VQ should be enabled if CTRL_RX is enabled. > Observed that virtio-net driver will crash if CTRL_VQ isn't enabled in vh= ost- > user case. > /* Caller should know better */ > BUG_ON(!virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ) || > (out + in > VIRTNET_SEND_COMMAND_SG_MAX)); Thanks for identifying, after your patch sent out to fix it, I will act it.= =20 Changchun