From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 9C2AB1288 for ; Fri, 16 Jan 2015 01:55:40 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 15 Jan 2015 16:52:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,407,1418112000"; d="scan'208";a="638046350" Received: from pgsmsx105.gar.corp.intel.com ([10.221.44.96]) by orsmga001.jf.intel.com with ESMTP; 15 Jan 2015 16:55:38 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by PGSMSX105.gar.corp.intel.com (10.221.44.96) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 16 Jan 2015 08:55:37 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.238]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.192]) with mapi id 14.03.0195.001; Fri, 16 Jan 2015 08:55:35 +0800 From: "Ouyang, Changchun" To: Stephen Hemminger Thread-Topic: [PATCH 18/22] virtio: Fix descriptor index issue Thread-Index: AQHQMIJus9b1g4uO1km3ZIN4B466A5zA4JkAgAEL9XA= Date: Fri, 16 Jan 2015 00:55:35 +0000 Message-ID: References: <1421298930-15210-1-git-send-email-changchun.ouyang@intel.com> <1421298930-15210-19-git-send-email-changchun.ouyang@intel.com> <20150115085402.4f418084@urahara> In-Reply-To: <20150115085402.4f418084@urahara> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 18/22] virtio: Fix descriptor index issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jan 2015 00:55:41 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Friday, January 16, 2015 12:54 AM > To: Ouyang, Changchun > Cc: dev@dpdk.org; Doherty, Declan; Cao, Waterman > Subject: Re: [PATCH 18/22] virtio: Fix descriptor index issue >=20 > On Thu, 15 Jan 2015 13:15:26 +0800 > Ouyang Changchun wrote: >=20 > > It should use vring descriptor index instead of used_ring index to inde= x > vq_descx. > > > > Signed-off-by: Changchun Ouyang > > --- > > lib/librte_pmd_virtio/virtio_rxtx.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/librte_pmd_virtio/virtio_rxtx.c > > b/lib/librte_pmd_virtio/virtio_rxtx.c > > index 12c2310..2529dc4 100644 > > --- a/lib/librte_pmd_virtio/virtio_rxtx.c > > +++ b/lib/librte_pmd_virtio/virtio_rxtx.c > > @@ -144,9 +144,9 @@ virtio_xmit_cleanup(struct virtqueue *vq, uint16_t > > num) > > > > used_idx =3D (uint16_t)(vq->vq_used_cons_idx & (vq- > >vq_nentries - 1)); > > uep =3D &vq->vq_ring.used->ring[used_idx]; > > - dxp =3D &vq->vq_descx[used_idx]; > > > > desc_idx =3D (uint16_t) uep->id; > > + dxp =3D &vq->vq_descx[desc_idx]; > > vq->vq_used_cons_idx++; > > vq_ring_free_chain(vq, desc_idx); > > >=20 > Rather than patching a code added by earlier patch in series, why not jus= t > fix/merge the two patches? I think it could be more clear what's the original patch looks like and wha= t I need to fix. And I also resolve the patch author issue, which I am not care for, but som= eone may care for. :-)=20 Thanks Changchun