From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 1ACCECF9 for ; Mon, 19 Jan 2015 05:51:41 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 18 Jan 2015 20:51:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="442126465" Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82]) by FMSMGA003.fm.intel.com with ESMTP; 18 Jan 2015 20:38:28 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by PGSMSX103.gar.corp.intel.com (10.221.44.82) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 19 Jan 2015 12:51:39 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.238]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.64]) with mapi id 14.03.0195.001; Mon, 19 Jan 2015 12:51:37 +0800 From: "Ouyang, Changchun" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v6 0/6] Enable VF RSS for Niantic Thread-Index: AQHQLizqiekin3WmZkuFIqvPs656X5zF+IIAgADw49A= Date: Mon, 19 Jan 2015 04:51:36 +0000 Message-ID: References: <1420612355-6666-1-git-send-email-changchun.ouyang@intel.com> <1421042352-22399-1-git-send-email-changchun.ouyang@intel.com> <2500048.zNVo70YcKP@xps13> In-Reply-To: <2500048.zNVo70YcKP@xps13> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v6 0/6] Enable VF RSS for Niantic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jan 2015 04:51:42 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, January 19, 2015 6:24 AM > To: Ouyang, Changchun > Cc: dev@dpdk.org; Vladislav Zolotarov; Butler, Siobhan A; Iremonger, > Bernard > Subject: Re: [dpdk-dev] [PATCH v6 0/6] Enable VF RSS for Niantic >=20 > > This patch enables VF RSS for Niantic, which allow each VF having at mo= st 4 > queues. > > The actual queue number per VF depends on the total number of pool, > > which is determined by the max number of VF at PF initialization stage > > and the number of queue specified in config: > > 1) If the max number of VF is in the range from 1 to 32, and the > > number of rxq is 4 ('--rxq 4' in testpmd), then there is totally 32 > > pools(ETH_32_POOLS), and each VF have 4 queues; > > > > 2)If the max number of VF is in the range from 33 to 64, and the > > number of rxq is 2 ('--rxq 2' in testpmd), then there is totally 64 > > pools(ETH_64_POOLS), and each VF have 2 queues; > > > > On host, to enable VF RSS functionality, rx mq mode should be set as > > ETH_MQ_RX_VMDQ_RSS or ETH_MQ_RX_RSS mode, and SRIOV mode > should be activated(max_vfs >=3D 1). > > It also needs config VF RSS information like hash function, RSS key, RS= S key > length. > > > > The limitation for Niantic VF RSS is: > > the hash and key are shared among PF and all VF, the RETA table with > > 128 entries are also shared among PF and all VF. So it could not to > > provide a method to query the hash and reta content per VF on guest, > > while, if possible, please query them on host(PF) for the shared RETA > information. >=20 > This kind of information should go in a documentation. > I think we should start new documentation for PMDs. > What about a doc/drivers/ directory ? Ok, before the new doc starts, I will consider putting it into program guid= e or user guide doc. =20 > > changes in v6: > > - refine codes and update message according to comments; > > > > changes in v5: > > - Fix minor issue and some comments; > > > > changes in v4: > > - Extract a function to remove embeded switch-case statement; > > - Check whether RX queue number is a valid one, otherwise return erro= r; > > - Update the description a bit; > > > > changes in v3: > > - More cleanup; > > > > changes in v2: > > - Update the description; > > - Use receiving queue number('--rxq ') specified in config to > determine the > > number of pool and the number of queue per VF; > > > > changes in v1: > > - Config VF RSS; > > > > Changchun Ouyang (6): > > ixgbe: Code cleanup > > ixgbe: Negotiate VF API version > > ixgbe: Get VF queue number > > ether: Check VMDq RSS mode > > ixgbe: Config VF RSS > > testpmd: Set Rx VMDq RSS mode >=20 > Deeply reviewed by Vlad Zolotarov. Thanks! >=20 > Applied >=20 Thanks very much for merging! Best regards Changchun