From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <changchun.ouyang@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 90D075A6F
 for <dev@dpdk.org>; Tue, 20 Jan 2015 02:33:17 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga101.jf.intel.com with ESMTP; 19 Jan 2015 17:33:13 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.09,430,1418112000"; d="scan'208";a="639608367"
Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78])
 by orsmga001.jf.intel.com with ESMTP; 19 Jan 2015 17:33:12 -0800
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
 PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS)
 id 14.3.195.1; Tue, 20 Jan 2015 09:32:49 +0800
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.238]) by
 SHSMSX151.ccr.corp.intel.com ([169.254.3.92]) with mapi id 14.03.0195.001;
 Tue, 20 Jan 2015 09:32:48 +0800
From: "Ouyang, Changchun" <changchun.ouyang@intel.com>
To: "Wodkowski, PawelX" <pawelx.wodkowski@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v2 2/4] ethdev: prevent changing of
 nb_q_per_pool	in rte_eth_dev_check_mq_mode()
Thread-Index: AQHQM+sMjEpd7a9ow0y282UuBvJD95zION2w
Date: Tue, 20 Jan 2015 01:32:48 +0000
Message-ID: <F52918179C57134FAEC9EA62FA2F96251197C623@shsmsx102.ccr.corp.intel.com>
References: <1421077843-8492-1-git-send-email-michalx.k.jastrzebski@intel.com>
 <1421672551-11652-1-git-send-email-pawelx.wodkowski@intel.com>
 <1421672551-11652-3-git-send-email-pawelx.wodkowski@intel.com>
In-Reply-To: <1421672551-11652-3-git-send-email-pawelx.wodkowski@intel.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 2/4] ethdev: prevent changing of
 nb_q_per_pool	in rte_eth_dev_check_mq_mode()
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Jan 2015 01:33:18 -0000



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pawel Wodkowski
> Sent: Monday, January 19, 2015 9:02 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2 2/4] ethdev: prevent changing of
> nb_q_per_pool in rte_eth_dev_check_mq_mode()
>=20
> If SRIOV is used and device configuration does not use MQ the
> RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool is set to 1 in
> rte_eth_dev_check_mq_mode().
> This is bad becouse of two reasons:
> 1. Port reconfiguration from non-MQ mode to MQ mode is impossible 2.
> Confguring RX and TX side in different way is impossible.
>=20

This case is possible:
rxmode.mq_mode is ETH_MQ_RX_VMDQ_RSS, and txmode.mq_mode is ETH_MQ_TX_NONE.