From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 49A271F5 for ; Wed, 28 Jan 2015 02:36:01 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 27 Jan 2015 17:35:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="446136588" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by FMSMGA003.fm.intel.com with ESMTP; 27 Jan 2015 17:22:07 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by PGSMSX107.gar.corp.intel.com (10.221.44.105) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 28 Jan 2015 09:35:02 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.238]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.168]) with mapi id 14.03.0195.001; Wed, 28 Jan 2015 09:35:01 +0800 From: "Ouyang, Changchun" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf rss Thread-Index: AQHQNSvO+u8e4Fyt0UOO6KEjTDQfhZzTZKKAgAFliBA= Date: Wed, 28 Jan 2015 01:35:00 +0000 Message-ID: References: <1421811523-18737-1-git-send-email-changchun.ouyang@intel.com> <1561845.4QtzaTeLCI@xps13> In-Reply-To: <1561845.4QtzaTeLCI@xps13> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf rss X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jan 2015 01:36:07 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, January 27, 2015 8:13 PM > To: Ouyang, Changchun > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf rss >=20 > > To follow up the comments from Wodkowski, PawelX, remove this > > unnecessary check, as check_mq_mode has already check the queue > number > > in device configure stage, if the queue number of vf is not correct, > > it will return error code and exit, so it doesn't need check again > > here in device start stage(note: pf_host_configure is called in device = start > stage). > > > > This fixes commit 42d2f78abcb77ecb769be4149df550308169ef0f > > > > Signed-off-by: Changchun Ouyang >=20 > Suggested-by: Pawel Wodkowski > Fixes: 42d2f78abcb77 ("configure VF RSS") >=20 > Applied >=20 Thanks very much for the applying! > Changchun, as you are working on ixgbe, maybe you would like to review > some ixgbe patches from others? >=20 No problem, I will try to do it when my bandwidth allows me to do it, :-) Thanks Changchun