From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 40E3B5AA6 for ; Fri, 30 Jan 2015 02:20:28 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 29 Jan 2015 17:13:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,489,1418112000"; d="scan'208";a="644808310" Received: from pgsmsx104.gar.corp.intel.com ([10.221.44.91]) by orsmga001.jf.intel.com with ESMTP; 29 Jan 2015 17:20:08 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by PGSMSX104.gar.corp.intel.com (10.221.44.91) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 30 Jan 2015 09:20:06 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.231]) with mapi id 14.03.0195.001; Fri, 30 Jan 2015 09:20:05 +0800 From: "Ouyang, Changchun" To: "Wodkowski, PawelX" , Thomas Monjalon , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf rss Thread-Index: AQHQNSvO+u8e4Fyt0UOO6KEjTDQfhZzTZKKAgAFliBCAAgKDgIABHMYg Date: Fri, 30 Jan 2015 01:20:05 +0000 Message-ID: References: <1421811523-18737-1-git-send-email-changchun.ouyang@intel.com> <1561845.4QtzaTeLCI@xps13> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf rss X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jan 2015 01:20:28 -0000 Hi PawelX > -----Original Message----- > From: Wodkowski, PawelX > Sent: Friday, January 30, 2015 12:14 AM > To: Ouyang, Changchun; Thomas Monjalon; Richardson, Bruce > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf rss >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ouyang, > Changchun > > Sent: Wednesday, January 28, 2015 2:35 AM > > To: Thomas Monjalon > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf > > rss > > > > Hi Thomas, > > > > > -----Original Message----- > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > Sent: Tuesday, January 27, 2015 8:13 PM > > > To: Ouyang, Changchun > > > Cc: dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in > > > vf rss > > > > > > > To follow up the comments from Wodkowski, PawelX, remove this > > > > unnecessary check, as check_mq_mode has already check the queue > > > number > > > > in device configure stage, if the queue number of vf is not > > > > correct, it will return error code and exit, so it doesn't need > > > > check again here in device start stage(note: pf_host_configure is > > > > called in device start > > > stage). > > > > > > > > This fixes commit 42d2f78abcb77ecb769be4149df550308169ef0f > > > > > > > > Signed-off-by: Changchun Ouyang > > > > > > Suggested-by: Pawel Wodkowski > > > Fixes: 42d2f78abcb77 ("configure VF RSS") > > > > > > Applied > > > > > > > Thanks very much for the applying! > > > > > Changchun, as you are working on ixgbe, maybe you would like to > > > review some ixgbe patches from others? > > > > > > > No problem, I will try to do it when my bandwidth allows me to do it, > > :-) Thanks Changchun >=20 > Actually I was suggesting exactly opposite direction. Main issue is that = the > sriov field in rte_eth_dev_data is only used by igb and ixgbe drivers. In > addition > rte_eth_dev_check_mq_mode() is specialized for ixgbe driver. >=20 > I am thinking about moving sriov from rte_eth_dev_data to driver's privat= e > structure or at least move rte_eth_dev_check_mq_mode() to struct > eth_dev_ops as optional driver configuration step. >=20 > What do you think about both steps? Good opinion! I prefer to move rte_eth_dev_check_mq_mode to eth_dev_ops as optional drive= r configure, The reason is that in future other eth type may also need such kind of chec= k or even refine some queue number values by their own way, I can help review your patch after you send out.=20 Thanks for your enhancing that. Changchun =20