From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 8CABA106B for ; Thu, 26 Mar 2015 04:33:09 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 25 Mar 2015 20:33:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,469,1422950400"; d="scan'208";a="472774021" Received: from pgsmsx108.gar.corp.intel.com ([10.221.44.103]) by FMSMGA003.fm.intel.com with ESMTP; 25 Mar 2015 20:33:07 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by PGSMSX108.gar.corp.intel.com (10.221.44.103) with Microsoft SMTP Server (TLS) id 14.3.224.2; Thu, 26 Mar 2015 11:32:47 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.198]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.36]) with mapi id 14.03.0224.002; Thu, 26 Mar 2015 11:32:46 +0800 From: "Ouyang, Changchun" To: "Ananyev, Konstantin" , Zoltan Kiss , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] examples/vhost: use library routines instead of local copies Thread-Index: AQHQZ05xOpXCvu6J9Eeh/nMPacDE5Z0tcXOAgACqhVA= Date: Thu, 26 Mar 2015 03:32:46 +0000 Message-ID: References: <1427309006-26590-1-git-send-email-zoltan.kiss@linaro.org> <2601191342CEEE43887BDE71AB97725821407936@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB97725821407936@irsmsx105.ger.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/vhost: use library routines instead of local copies X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Mar 2015 03:33:10 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ananyev, > Konstantin > Sent: Thursday, March 26, 2015 9:21 AM > To: Zoltan Kiss; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] examples/vhost: use library routines > instead of local copies >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zoltan Kiss > > Sent: Wednesday, March 25, 2015 6:43 PM > > To: dev@dpdk.org > > Cc: Zoltan Kiss > > Subject: [dpdk-dev] [PATCH] examples/vhost: use library routines > > instead of local copies > > > > This macro and function were copies from the mbuf library, no reason > > to keep them. >=20 > NACK > You can't use RTE_MBUF_INDIRECT macro here. > If you'll look at vhost code carefully, you'll realise that we don't use = standard > rte_pktmbuf_attach() here. > As we attach mbuf not to another mbuf but to external memory buffer, > passed to us by virtio device. > Look at attach_rxmbuf_zcp(). > Though I suppose, we can replace pktmbuf_detach_zcp() , with > rte_pktmbuf_detach() - they are doing identical things. > BTW, I wonder did you ever test your patch? > My guess it would cause vhost with '--zero-copy' to crash or corrupt the > packets straightway. >=20 > Konstantin >=20 > > > > Signed-off-by: Zoltan Kiss NACK this patch, Same reason with Konstantin. Changchun