From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 926E95ABA for ; Thu, 11 Jun 2015 07:57:44 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 10 Jun 2015 22:57:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,592,1427785200"; d="scan'208";a="506500207" Received: from pgsmsx104.gar.corp.intel.com ([10.221.44.91]) by FMSMGA003.fm.intel.com with ESMTP; 10 Jun 2015 22:57:41 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by PGSMSX104.gar.corp.intel.com (10.221.44.91) with Microsoft SMTP Server (TLS) id 14.3.224.2; Thu, 11 Jun 2015 13:56:09 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.165]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.246]) with mapi id 14.03.0224.002; Thu, 11 Jun 2015 13:56:08 +0800 From: "Ouyang, Changchun" To: Stephen Hemminger , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 5/5] virtio: clarify feature bit handling Thread-Index: AQHQd4/pbLKrGM39fkOli9LRj43DeZ2kuR8AgAJtwzA= Date: Thu, 11 Jun 2015 05:56:07 +0000 Message-ID: References: <1429111219-8789-1-git-send-email-stephen@networkplumber.org> <1429111219-8789-6-git-send-email-stephen@networkplumber.org> <20150609174834.3c6006ac@urahara> In-Reply-To: <20150609174834.3c6006ac@urahara> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 5/5] virtio: clarify feature bit handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jun 2015 05:57:45 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen > Hemminger > Sent: Wednesday, June 10, 2015 8:49 AM > To: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 5/5] virtio: clarify feature bit handling >=20 > On Wed, 15 Apr 2015 08:20:19 -0700 > Stephen Hemminger wrote: >=20 > > Change the features from bit mask to bit number. This allows the DPDK > > driver to use the definitions from Linux[1]. This makes doing > > enhancements to DPDK driver easier when new feature bits are added. > > > > More importantly, get rid of the confusing feature bit initialization > > code. Remove the double negative code in the feature masking. > > Instead just have a new define with the list of feature bits implemente= d. > > > > Signed-off-by: Stephen Hemminger > > --- > > lib/librte_pmd_virtio/virtio_ethdev.c | 17 +------ > > lib/librte_pmd_virtio/virtio_ethdev.h | 27 ++++------ > > lib/librte_pmd_virtio/virtio_pci.h | 96 ++++++++++++++++++---------= ----- As the path for virtio codes is moved to drivers/net/virtio, so need a v2 v= ersion to rebase it. Thanks Changchun