From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 95F8CC62C for ; Fri, 19 Jun 2015 03:07:34 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 18 Jun 2015 18:07:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,641,1427785200"; d="scan'208";a="713640651" Received: from pgsmsx105.gar.corp.intel.com ([10.221.44.96]) by orsmga001.jf.intel.com with ESMTP; 18 Jun 2015 18:07:32 -0700 Received: from kmsmsx154.gar.corp.intel.com (172.21.73.14) by PGSMSX105.gar.corp.intel.com (10.221.44.96) with Microsoft SMTP Server (TLS) id 14.3.224.2; Fri, 19 Jun 2015 09:06:07 +0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by KMSMSX154.gar.corp.intel.com (172.21.73.14) with Microsoft SMTP Server (TLS) id 14.3.224.2; Fri, 19 Jun 2015 09:06:06 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.165]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.129]) with mapi id 14.03.0224.002; Fri, 19 Jun 2015 09:06:05 +0800 From: "Ouyang, Changchun" To: Flavio Leitner Thread-Topic: [dpdk-dev] [PATCH v3 2/9] lib_vhost: Support multiple queues in virtio dev Thread-Index: AQHQp0DeP7MJcfzIlUahP6K+INfs0J2xvW0AgAFMHAA= Date: Fri, 19 Jun 2015 01:06:04 +0000 Message-ID: References: <1433915549-18571-1-git-send-email-changchun.ouyang@intel.com> <1434355006-30583-1-git-send-email-changchun.ouyang@intel.com> <1434355006-30583-3-git-send-email-changchun.ouyang@intel.com> <20150618131644.GC2574@x240.home> In-Reply-To: <20150618131644.GC2574@x240.home> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 2/9] lib_vhost: Support multiple queues in virtio dev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2015 01:07:35 -0000 Hi Flavio, > -----Original Message----- > From: Flavio Leitner [mailto:fbl@sysclose.org] > Sent: Thursday, June 18, 2015 9:17 PM > To: Ouyang, Changchun > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/9] lib_vhost: Support multiple queues= in > virtio dev >=20 > On Mon, Jun 15, 2015 at 03:56:39PM +0800, Ouyang Changchun wrote: > > Each virtio device could have multiple queues, say 2 or 4, at most 8. > > Enabling this feature allows virtio device/port on guest has the > > ability to use different vCPU to receive/transmit packets from/to each > queue. > > > > In multiple queues mode, virtio device readiness means all queues of > > this virtio device are ready, cleanup/destroy a virtio device also > > requires clearing all queues belong to it. > > > > Changes in v3: > > - fix coding style > > - check virtqueue idx validity > > > > Changes in v2: > > - remove the q_num_set api > > - add the qp_num_get api > > - determine the queue pair num from qemu message > > - rework for reset owner message handler > > - dynamically alloc mem for dev virtqueue > > - queue pair num could be 0x8000 > > - fix checkpatch errors > > > > Signed-off-by: Changchun Ouyang > [...] >=20 > > diff --git a/lib/librte_vhost/virtio-net.c > > b/lib/librte_vhost/virtio-net.c index fced2ab..aaea7d5 100644 > > --- a/lib/librte_vhost/virtio-net.c > > +++ b/lib/librte_vhost/virtio-net.c > > @@ -67,10 +67,10 @@ static struct virtio_net_config_ll *ll_root; > > #define VHOST_SUPPORTED_FEATURES ((1ULL << > VIRTIO_NET_F_MRG_RXBUF) | \ > > (1ULL << VIRTIO_NET_F_CTRL_VQ) | \ > > (1ULL << VIRTIO_NET_F_CTRL_RX) | \ > > - (1ULL << VHOST_F_LOG_ALL)) > > + (1ULL << VHOST_F_LOG_ALL)) | \ > > + (1ULL << VIRTIO_NET_F_MQ)) >=20 > One extra parenthesis after VHOST_F_LOG_ALL BTW, this series need > rebase with latest dpdk. > fbl >=20 Yes, will updated it. Thanks Changchun