From: "Ouyang, Changchun" <changchun.ouyang@intel.com>
To: "Xie, Huawei" <huawei.xie@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] virtio: fix the vq size issue
Date: Thu, 2 Jul 2015 00:29:37 +0000 [thread overview]
Message-ID: <F52918179C57134FAEC9EA62FA2F962511BDCE1F@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <C37D651A908B024F974696C65296B57B0F5504FB@SHSMSX101.ccr.corp.intel.com>
Hi huawei,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xie, Huawei
> Sent: Wednesday, July 1, 2015 11:53 PM
> To: dev@dpdk.org; Thomas Monjalon
> Subject: Re: [dpdk-dev] [PATCH] virtio: fix the vq size issue
>
> On 7/1/2015 3:49 PM, Ouyang Changchun wrote:
> > This commit breaks virtio basic packets rx functionality:
> > d78deadae4dca240e85054bf2d604a801676becc
> >
> > The QEMU use 256 as default vring size, also use this default value to
> > calculate the virtio avail ring base address and used ring base
> > address, and vhost in the backend use the ring base address to do packet
> IO.
> >
> > Virtio spec also says the queue size in PCI configuration is
> > read-only, so virtio front end can't change it. just need use the
> > read-only value to allocate space for vring and calculate the avail
> > and used ring base address. Otherwise, the avail and used ring base
> address will be different between host and guest, accordingly, packet IO
> can't work normally.
> virtio driver could still use the vq_size to initialize avail ring and use ring so
> that they still have the same base address.
> The other issue is vhost use index & (vq->size -1) to index the ring.
I am not sure what is your clear message here,
Vhost has no choice but use vq->size -1 to index the ring,
It is qemu that always use 256 as the vq size, and set the avail and used ring base address,
It also tells vhost the vq size is 256.
>
>
> Thomas:
> This fix works but introduces slight change with original code. Could we just
> rollback that commit?
What's your major concern for the slight change here?
just removing the unnecessary check for nb_desc itself.
So I think no issue for the slight change.
Thanks
Changchun
next prev parent reply other threads:[~2015-07-02 0:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 7:48 Ouyang Changchun
2015-07-01 8:55 ` Xu, Qian Q
2015-07-01 15:53 ` Xie, Huawei
2015-07-02 0:29 ` Ouyang, Changchun [this message]
2015-07-02 2:01 ` Xie, Huawei
2015-07-02 2:16 ` Ouyang, Changchun
2015-07-02 9:15 ` Xie, Huawei
2015-07-03 1:53 ` Ouyang, Changchun
2015-07-10 14:05 ` Xie, Huawei
2015-07-10 14:11 ` Thomas Monjalon
2015-07-13 1:40 ` Ouyang, Changchun
2015-07-07 2:32 ` Ouyang, Changchun
2015-07-17 10:42 ` Thomas Monjalon
2015-07-17 16:27 ` Stephen Hemminger
2015-07-18 12:11 ` Ouyang, Changchun
2015-07-20 15:47 ` Stephen Hemminger
2015-07-20 3:40 ` Xu, Qian Q
2015-07-20 6:18 ` Ouyang, Changchun
2015-07-20 10:42 ` Thomas Monjalon
2015-07-21 5:23 ` Ouyang, Changchun
2015-07-20 15:30 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F52918179C57134FAEC9EA62FA2F962511BDCE1F@shsmsx102.ccr.corp.intel.com \
--to=changchun.ouyang@intel.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).