From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 3A3D35A43 for ; Wed, 8 Jul 2015 02:42:28 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 07 Jul 2015 17:42:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,427,1432623600"; d="scan'208";a="520463521" Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80]) by FMSMGA003.fm.intel.com with ESMTP; 07 Jul 2015 17:42:27 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by PGSMSX102.gar.corp.intel.com (10.221.44.80) with Microsoft SMTP Server (TLS) id 14.3.224.2; Wed, 8 Jul 2015 08:42:26 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.165]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.129]) with mapi id 14.03.0224.002; Wed, 8 Jul 2015 08:42:19 +0800 From: "Ouyang, Changchun" To: "Iremonger, Bernard" , "dev@dpdk.org" Thread-Topic: [PATCH v4 4/4] test-pmd: remove call to rte_eth_promiscuous_disable() from detach_port() Thread-Index: AQHQuJXpBgQIltyi0UCgeIqkADt/eJ3QuP7Q Date: Wed, 8 Jul 2015 00:42:19 +0000 Message-ID: References: <1436260687-28549-1-git-send-email-bernard.iremonger@intel.com> <1436260687-28549-5-git-send-email-bernard.iremonger@intel.com> In-Reply-To: <1436260687-28549-5-git-send-email-bernard.iremonger@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 4/4] test-pmd: remove call to rte_eth_promiscuous_disable() from detach_port() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2015 00:42:28 -0000 > -----Original Message----- > From: Iremonger, Bernard > Sent: Tuesday, July 7, 2015 5:18 PM > To: dev@dpdk.org > Cc: Ouyang, Changchun; Iremonger, Bernard > Subject: [PATCH v4 4/4] test-pmd: remove call to > rte_eth_promiscuous_disable() from detach_port() >=20 > At this point the stop() and close() functions have already been called. > The rte_eth_promiscuous_disable() function does not return on the VM. I think we need root the cause why it doesn't return on the VM. >=20 > Signed-off-by: Bernard Iremonger > --- > app/test-pmd/testpmd.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > 82b465d..4769533 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -1,7 +1,7 @@ > /*- > * BSD LICENSE > * > - * Copyright(c) 2010-2014 Intel Corporation. All rights reserved. > + * Copyright(c) 2010-2015 Intel Corporation. All rights reserved. > * All rights reserved. > * > * Redistribution and use in source and binary forms, with or without > @@ -1542,8 +1542,6 @@ detach_port(uint8_t port_id) > return; > } >=20 > - rte_eth_promiscuous_disable(port_id); > - It seems a workaround. > if (rte_eth_dev_detach(port_id, name)) > return; >=20 > -- > 1.7.4.1