From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 2247E594B for ; Wed, 9 Sep 2015 03:43:17 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 08 Sep 2015 18:43:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,493,1437462000"; d="scan'208";a="801098444" Received: from kmsmsx151.gar.corp.intel.com ([172.21.73.86]) by fmsmga002.fm.intel.com with ESMTP; 08 Sep 2015 18:43:15 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by KMSMSX151.gar.corp.intel.com (172.21.73.86) with Microsoft SMTP Server (TLS) id 14.3.224.2; Wed, 9 Sep 2015 09:43:07 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.171]) with mapi id 14.03.0224.002; Wed, 9 Sep 2015 09:43:06 +0800 From: "Ouyang, Changchun" To: Yuanhan Liu , "dev@dpdk.org" Thread-Topic: [PATCH 4/4] vhost: define callfd and kickfd as int type Thread-Index: AQHQ3iCPtDbXKS+To0WkMPcOL/s6yJ4zhJag Date: Wed, 9 Sep 2015 01:43:06 +0000 Message-ID: References: <1440388485-13554-1-git-send-email-yuanhan.liu@linux.intel.com> <1440388485-13554-4-git-send-email-yuanhan.liu@linux.intel.com> In-Reply-To: <1440388485-13554-4-git-send-email-yuanhan.liu@linux.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 4/4] vhost: define callfd and kickfd as int type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Sep 2015 01:43:18 -0000 > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Monday, August 24, 2015 11:55 AM > To: dev@dpdk.org > Cc: Xie, Huawei; Ouyang, Changchun; Yuanhan Liu > Subject: [PATCH 4/4] vhost: define callfd and kickfd as int type >=20 > So that we can remove the redundant (int) cast. >=20 > Signed-off-by: Yuanhan Liu > --- > diff --git a/lib/librte_vhost/rte_virtio_net.h > b/lib/librte_vhost/rte_virtio_net.h > index b9bf320..a037c15 100644 > --- a/lib/librte_vhost/rte_virtio_net.h > +++ b/lib/librte_vhost/rte_virtio_net.h > @@ -87,8 +87,8 @@ struct vhost_virtqueue { > uint16_t vhost_hlen; /**< Vhost header > length (varies depending on RX merge buffers. */ > volatile uint16_t last_used_idx; /**< Last index used > on the available ring */ > volatile uint16_t last_used_idx_res; /**< Used for > multiple devices reserving buffers. */ > - eventfd_t callfd; /**< Used to notify > the guest (trigger interrupt). */ > - eventfd_t kickfd; /**< Currently > unused as polling mode is enabled. */ > + int callfd; /**< Used to notify > the guest (trigger interrupt). */ > + int kickfd; /**< Currently > unused as polling mode is enabled. */ I don't think we have to change it from 8B(eventfd_t is defined as uint64_t= ) to 4B, Any benefit for this change?=20