From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id ACD908E73 for ; Thu, 26 Apr 2018 18:44:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2018 09:44:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,330,1520924400"; d="scan'208";a="223608888" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga005.fm.intel.com with ESMTP; 26 Apr 2018 09:44:40 -0700 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.37]) by IRSMSX103.ger.corp.intel.com ([169.254.3.61]) with mapi id 14.03.0319.002; Thu, 26 Apr 2018 17:44:39 +0100 From: "Daly, Lee" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "Tucker, Greg B" , "Jain, Deepak K" , "Trahe, Fiona" Thread-Topic: [PATCH v3 05/11] compress/isal: add queue pair related ops Thread-Index: AQHT1lEKgvGpTM+go0ORSw20rgxgk6QPp4iAgAOl/gA= Date: Thu, 26 Apr 2018 16:44:39 +0000 Message-ID: References: <1523038388-29964-1-git-send-email-lee.daly@intel.com> <1523972132-6894-1-git-send-email-lee.daly@intel.com> <1523972132-6894-6-git-send-email-lee.daly@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWEyMmE4MjgtODE3Yy00ZTFiLThkNWMtYWRiZGQ2ZThkOGViIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiIwMFBaQWpsdnZvZW4xUEJGaWNIOVg0Y1J1OW5ZUWdqU2szV3lOSUFQcWVMNlpPWm9FU0hpQ2FDSCtyVk5ta0F5In0= x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 05/11] compress/isal: add queue pair related ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 16:44:43 -0000 <...> > > -----Original Message----- > > From: Daly, Lee > > Sent: Tuesday, April 17, 2018 2:35 PM > > To: dev@dpdk.org > > Cc: De Lara Guarch, Pablo ; Tucker, > > Greg B ; Jain, Deepak K > > ; Trahe, Fiona ; Daly, > > Lee > > Subject: [PATCH v3 05/11] compress/isal: add queue pair related ops > > > > Signed-off-by: Lee Daly > > --- > > drivers/compress/isal/isal_compress_pmd_ops.c | 110 > > +++++++++++++++++++++- > > drivers/compress/isal/isal_compress_pmd_private.h | 2 + > > 2 files changed, 110 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c > > b/drivers/compress/isal/isal_compress_pmd_ops.c > > index 2e9381d..73e4c84 100644 > > --- a/drivers/compress/isal/isal_compress_pmd_ops.c //snip >=20 > > +qp_id */ static int isal_comp_pmd_qp_set_unique_name(struct > > +rte_compressdev *dev, struct isal_comp_qp *qp) { > > + unsigned int n =3D snprintf(qp->name, sizeof(qp->name), > > + "isal_compression_pmd_%u_qp_%u", > > + dev->data->dev_id, qp->id); >=20 > Better to use strlcpy. [Lee] I believe snprintf to be a better fit due to the fact strlcpy doesn't= handle variable arguments as inputs, i.e=20 "snprintf(dst, length, "%s", src)"=20 "strlcpy(dst, src, length)" To complete this action with strlcpy would cause more overhead, and snprint= f() is still safe as it always null terminates. >=20 > > + > > + if (n >=3D sizeof(qp->name)) > > + return -1; > > + > > + return 0; > > +}