From: "Daly, Lee" <lee.daly@intel.com>
To: Shally Verma <shally.verma@caviumnetworks.com>
Cc: "Trahe, Fiona" <fiona.trahe@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"pathreay@caviumnetworks.com" <pathreay@caviumnetworks.com>,
Sunila Sahu <sunila.sahu@caviumnetworks.com>,
Ashish Gupta <ashish.gupta@caviumnetworks.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1 3/6] compress/zlib: add xform and stream create support
Date: Fri, 15 Jun 2018 11:09:08 +0000 [thread overview]
Message-ID: <F5C6929789601049BEB7272E2673559857498F@IRSMSX106.ger.corp.intel.com> (raw)
In-Reply-To: <1526380346-7386-4-git-send-email-shally.verma@caviumnetworks.com>
Comment Inline.
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shally Verma
> Sent: Tuesday, May 15, 2018 11:32 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: Trahe, Fiona <fiona.trahe@intel.com>; dev@dpdk.org;
> pathreay@caviumnetworks.com; Sunila Sahu
> <sunila.sahu@caviumnetworks.com>; Ashish Gupta
> <ashish.gupta@caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH v1 3/6] compress/zlib: add xform and stream
> create support
>
> Implement private xform and stream create ops
>
<...>
> struct rte_compressdev_ops zlib_pmd_ops = {
> .dev_configure = zlib_pmd_config,
> .dev_start = zlib_pmd_start,
> @@ -228,11 +304,11 @@ struct rte_compressdev_ops zlib_pmd_ops = {
> .queue_pair_setup = zlib_pmd_qp_setup,
> .queue_pair_release = zlib_pmd_qp_release,
>
> - .private_xform_create = NULL,
> - .private_xform_free = NULL,
> + .private_xform_create = zlib_pmd_private_xform_create,
> + .private_xform_free =
> zlib_pmd_private_xform_free,
[Lee] Quick fix of formatting here please.
>
> - .stream_create = NULL,
> - .stream_free = NULL
> + .stream_create = zlib_pmd_stream_create,
> + .stream_free = zlib_pmd_stream_free
> };
>
> struct rte_compressdev_ops *rte_zlib_pmd_ops = &zlib_pmd_ops;
> --
> 2.9.5
Thanks,
Lee.
next prev parent reply other threads:[~2018-06-15 11:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 10:32 [dpdk-dev] [PATCH v1 0/6]compress: add zlib compression PMD Shally Verma
2018-05-15 10:32 ` [dpdk-dev] [PATCH v1 1/6] compress/zlib: add ZLIB PMD support Shally Verma
2018-06-15 11:08 ` Daly, Lee
2018-05-15 10:32 ` [dpdk-dev] [PATCH v1 2/6] compress/zlib: add device setup PMD ops Shally Verma
2018-06-15 11:08 ` Daly, Lee
2018-06-22 13:21 ` Verma, Shally
2018-06-25 10:05 ` Daly, Lee
2018-06-25 10:07 ` Verma, Shally
2018-05-15 10:32 ` [dpdk-dev] [PATCH v1 3/6] compress/zlib: add xform and stream create support Shally Verma
2018-06-15 11:09 ` Daly, Lee [this message]
2018-05-15 10:32 ` [dpdk-dev] [PATCH v1 4/6] compress/zlib: add enq deq apis Shally Verma
2018-06-15 11:09 ` Daly, Lee
2018-05-15 10:32 ` [dpdk-dev] [PATCH v1 5/6] test: add ZLIB PMD for compressdev tests Shally Verma
2018-05-15 10:32 ` [dpdk-dev] [PATCH v1 6/6] doc: add ZLIB PMD documentation Shally Verma
2018-06-15 11:09 ` Daly, Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F5C6929789601049BEB7272E2673559857498F@IRSMSX106.ger.corp.intel.com \
--to=lee.daly@intel.com \
--cc=ashish.gupta@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=pathreay@caviumnetworks.com \
--cc=shally.verma@caviumnetworks.com \
--cc=sunila.sahu@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).