From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 12BDC1D72B for ; Fri, 15 Jun 2018 13:09:22 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jun 2018 04:09:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,226,1526367600"; d="scan'208";a="49234791" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga007.jf.intel.com with ESMTP; 15 Jun 2018 04:09:19 -0700 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.80]) by IRSMSX104.ger.corp.intel.com ([169.254.5.212]) with mapi id 14.03.0319.002; Fri, 15 Jun 2018 12:09:19 +0100 From: "Daly, Lee" To: Shally Verma CC: "Trahe, Fiona" , "dev@dpdk.org" , "pathreay@caviumnetworks.com" , Sunila Sahu , Ashish Gupta , "De Lara Guarch, Pablo" Thread-Topic: [dpdk-dev] [PATCH v1 6/6] doc: add ZLIB PMD documentation Thread-Index: AQHT7DhQAlccNByU70yueberKT7qP6RhVv3w Date: Fri, 15 Jun 2018 11:09:17 +0000 Message-ID: References: <1526380346-7386-1-git-send-email-shally.verma@caviumnetworks.com> <1526380346-7386-7-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: <1526380346-7386-7-git-send-email-shally.verma@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmUxNmMxYjAtOTdmNS00NmE5LThmNGQtOGUwMDAzZjRjYzRiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJqYmxSa0hcL2laMmFWSENlVkwyYVwvQW9aZ1FTQTd1T2FtVzEwd285bFYrRnJkcW1sRXV6Q3lkaVRmVlRjQjFUYUkifQ== x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 6/6] doc: add ZLIB PMD documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2018 11:09:23 -0000 Hi, Comments inline. > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shally Verma > Sent: Tuesday, May 15, 2018 11:32 AM > To: De Lara Guarch, Pablo > Cc: Trahe, Fiona ; dev@dpdk.org; > pathreay@caviumnetworks.com; Sunila Sahu > ; Ashish Gupta > > Subject: [dpdk-dev] [PATCH v1 6/6] doc: add ZLIB PMD documentation >=20 > add zlib pmd feature specification and overview documentation >=20 > Signed-off-by: Sunila Sahu > Signed-off-by: Shally Verma > Signed-off-by: Ashish Gupta > --- > doc/guides/compressdevs/features/zlib.ini | 22 ++++++++++ > doc/guides/compressdevs/zlib.rst | 72 > +++++++++++++++++++++++++++++++ > 2 files changed, 94 insertions(+) >=20 > diff --git a/doc/guides/compressdevs/features/zlib.ini > b/doc/guides/compressdevs/features/zlib.ini > new file mode 100644 > index 0000000..10e758b > --- /dev/null > +++ b/doc/guides/compressdevs/features/zlib.ini > @@ -0,0 +1,22 @@ > +; > +; Refer to default.ini for the full list of available PMD features. > +; > +; Supported features of 'ZLIB' compression driver. > +; > +[Features] > +HW Accelerated =3D > +CPU SSE =3D > +CPU AVX =3D > +CPU AVX2 =3D > +CPU AVX512 =3D > +CPU NEON =3D > +Stateful =3D > +By-Pass =3D > +Chained mbufs =3D > +Deflate =3D Y > +LZS =3D > +Adler32 =3D Y > +Crc32 =3D Y [Lee] here you say you support both adler and crc checksums, in the feature= flags of the PMD it is says only adler32, but I see no implementation of a= ny checksums in the PMD?=20 Note* the checksum of the data will need to be put in the op->input_chksum = & op->output_chksum. > +Adler32&Crc32 =3D > +Fixed =3D Y > +Dynamic =3D Y > diff --git a/doc/guides/compressdevs/zlib.rst > b/doc/guides/compressdevs/zlib.rst > new file mode 100644 > index 0000000..130750b > --- /dev/null > +++ b/doc/guides/compressdevs/zlib.rst > @@ -0,0 +1,72 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > + Copyright(c) 2018 Cavium Networks. > + > +ZLIB Compression Poll Mode Driver > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > + > +The ZLIB PMD (**librte_pmd_zlib**) provides poll mode compression & > +decompression driver based on SW zlib library, > + > +Features > +-------- > + > +ZLIB PMD has support for: > + > +Compression/Decompression algorithm: > + > +* DEFLATE > + > +Huffman code type: > + > +* FIXED > +* DYNAMIC > + > +Checksum support: > + > +* Adler32 > +* CRC32 [Lee] see comment above. > + > +Window size support: > + > +* 32K [Lee] Say only 32K window size support here but in the capabilities of the = PMD you have a window_size ranging from 8(256) to 15(32k). You also have in= crements of 2, which wouldn't allow 15 as max. Thanks for the work, Lee.