From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 56DA25F16 for ; Mon, 25 Jun 2018 12:05:22 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jun 2018 03:05:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,270,1526367600"; d="scan'208";a="66085273" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by fmsmga004.fm.intel.com with ESMTP; 25 Jun 2018 03:05:20 -0700 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.80]) by IRSMSX109.ger.corp.intel.com ([169.254.13.225]) with mapi id 14.03.0319.002; Mon, 25 Jun 2018 11:05:19 +0100 From: "Daly, Lee" To: "Verma, Shally" CC: "Trahe, Fiona" , "dev@dpdk.org" , "pathreay@caviumnetworks.com" , "Sahu, Sunila" , "Gupta, Ashish" , "De Lara Guarch, Pablo" Thread-Topic: [dpdk-dev] [PATCH v1 2/6] compress/zlib: add device setup PMD ops Thread-Index: AQHT7Dgwqolm9e5EzUSvJW3z3OQoI6RgIh7QgAxMkgCABHPEMA== Date: Mon, 25 Jun 2018 10:05:18 +0000 Message-ID: References: <1526380346-7386-1-git-send-email-shally.verma@caviumnetworks.com> <1526380346-7386-3-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWUxN2IwMWUtOTA5Ny00YTA0LTlkYmEtMWQ0YzFjMTc2MGU4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJRM3B5V0tRTGp0eHdCVE9WMXZMbGhZR1wvRFcrYk9DU05kUXV2ZkpYQXJJSEtRRTU5U1pWeFpSR01RSFwvRjFvdFUifQ== x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 2/6] compress/zlib: add device setup PMD ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jun 2018 10:05:22 -0000 > > > >> -----Original Message----- > >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shally Verma > >> Sent: Tuesday, May 15, 2018 11:32 AM > >> To: De Lara Guarch, Pablo > >> Cc: Trahe, Fiona ; dev@dpdk.org; > >> pathreay@caviumnetworks.com; Sunila Sahu > >> ; Ashish Gupta > >> > >> Subject: [dpdk-dev] [PATCH v1 2/6] compress/zlib: add device setup > >> PMD ops > >> > >>diff --git a/drivers/compress/zlib/zlib_pmd_ops.c > >>b/drivers/compress/zlib/zlib_pmd_ops.c > >>new file mode 100644 > >>index 0000000..0bd42f3 > >>--- /dev/null > >>+++ b/drivers/compress/zlib/zlib_pmd_ops.c > >>@@ -0,0 +1,238 @@ > >>+/* SPDX-License-Identifier: BSD-3-Clause > >>+ * Copyright(c) 2018 Cavium Networks > >>+ */ > >>+ > >>+#include > >>+ > >>+#include > >>+#include > >>+#include > >>+ > >>+#include "zlib_pmd_private.h" > >>+ > >>+static const struct rte_compressdev_capabilities zlib_pmd_capabilities= [] > =3D { > >>+ { /* Deflate */ > >>+ .algo =3D RTE_COMP_ALGO_DEFLATE, > >>+ .comp_feature_flags =3D > RTE_COMP_FF_SHAREABLE_PRIV_XFORM, > >[Lee] The priv_xform structure in this case is not shareable, as it > >contains your zlib_stream structure, which contains zlibs own zstream > >struct. This is not read only, the contents of this zstream will be writ= ten to, > which means it is not shareable across queue pairs or devices. > > > [Shally] Per my understanding, SHAREABLE_PRIV_XFORM here means xform > is shareable by all ops in one single enqueue_burst() but not across devi= ces > or qps by multiple threads in parallel. Does your implementation support > such usage of shareable priv_xforms? >=20 > Thanks for review. > Shally [Lee] Hey Shally, I have just clarified this with Fiona and Pablo and the intende= d use of Shareable priv xforms is to allow a xform to be shared across devi= ces & qps not just all the ops in a burst, yes the ISA-L PMD has a shareabl= e private xform due to all its contents being read only.=20 >=20 > >>+ .window_size =3D { > >>+ .min =3D 8, > >>+ .max =3D 15, > >>+ .increment =3D 2 > >>+ }, > >>+ }, > >>+ > >>+ RTE_COMP_END_OF_CAPABILITIES_LIST() > >>+