From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 6FDC11B488; Wed, 11 Jul 2018 18:13:29 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2018 09:13:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,338,1526367600"; d="scan'208";a="66087160" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga002.fm.intel.com with ESMTP; 11 Jul 2018 09:13:27 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 11 Jul 2018 17:13:26 +0100 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.26]) by irsmsx112.ger.corp.intel.com ([169.254.1.22]) with mapi id 14.03.0319.002; Wed, 11 Jul 2018 17:13:26 +0100 From: "Daly, Lee" To: "De Lara Guarch, Pablo" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH 3/3] compress/isal: fix memory leak Thread-Index: AQHUGSWzpZNT2nuc4kOWKhvxgFIyN6SKMbGA Date: Wed, 11 Jul 2018 16:13:25 +0000 Message-ID: References: <20180711063846.47189-1-pablo.de.lara.guarch@intel.com> <20180711063846.47189-3-pablo.de.lara.guarch@intel.com> In-Reply-To: <20180711063846.47189-3-pablo.de.lara.guarch@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjhhZGQ3ZmUtYmI0NS00MTUyLTgzZWItNWU2M2ZhZWM2YmVjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJjVHNJcFhkSUdRMGdrTHUzTXdCM29QMGFlS1wvU3JzeGVhTjVJZnlpY3p2MCs2c3Rjd2hRYlZ3aU9XN2NMZWgwaCJ9 x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/3] compress/isal: fix memory leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jul 2018 16:13:30 -0000 > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Wednesday, July 11, 2018 7:39 AM > To: Daly, Lee > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > stable@dpdk.org > Subject: [PATCH 3/3] compress/isal: fix memory leak >=20 > Processed operations ring is created for each queue pair, but it was not = being > freed when the queue pair was released. >=20 > Fixes: b0e23c458a6f ("compress/isal: add queue pair related ops") > Cc: stable@dpdk.org >=20 > Signed-off-by: Pablo de Lara > --- > drivers/compress/isal/isal_compress_pmd_ops.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c > b/drivers/compress/isal/isal_compress_pmd_ops.c > index 0738fb9c4..c61acd40c 100644 > --- a/drivers/compress/isal/isal_compress_pmd_ops.c > +++ b/drivers/compress/isal/isal_compress_pmd_ops.c > @@ -167,6 +167,9 @@ isal_comp_pmd_qp_release(struct rte_compressdev > *dev, uint16_t qp_id) > if (qp->state !=3D NULL) > rte_free(qp->state); >=20 > + if (qp->processed_pkts !=3D NULL) > + rte_ring_free(qp->processed_pkts); > + > rte_free(qp); > dev->data->queue_pairs[qp_id] =3D NULL; >=20 > -- > 2.14.4 Acked-by: Lee Daly