From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id C62355592 for ; Mon, 17 Dec 2018 10:20:09 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2018 01:20:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,364,1539673200"; d="scan'208";a="128480002" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga004.fm.intel.com with ESMTP; 17 Dec 2018 01:20:08 -0800 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.227]) by IRSMSX103.ger.corp.intel.com ([169.254.3.157]) with mapi id 14.03.0415.000; Mon, 17 Dec 2018 09:20:07 +0000 From: "Daly, Lee" To: "Varghese, Vipin" , "akhil.goyal@nxp.com" CC: "dev@dpdk.org" , "Trahe, Fiona" Thread-Topic: [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum support in driver Thread-Index: AQHUleFOUhM8Lx3lGEeIT8AiGYNe+6WCpPjQ Date: Mon, 17 Dec 2018 09:20:07 +0000 Message-ID: References: <11544697752-156863-1-git-send-email-lee.daly@intel.com> <1544781564-63598-1-git-send-email-lee.daly@intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2DC5B7@BGSMSX101.gar.corp.intel.com> In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2DC5B7@BGSMSX101.gar.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzM1Yzc5YjYtMGM2NC00M2M3LTllNzItNDZjNGEzODM3YTVhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTHAyb1ZrWUdmNUtjTGJKSTN2SHlINzZPc2RVTEhJNjMrenBVWUtqcUErNExjVnNSNDJoOXhNbDV2VUdGOW4zUiJ9 x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum support in driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2018 09:20:10 -0000 Hi Vipin, thanks for the question. > -----Original Message----- > From: Varghese, Vipin > Sent: Monday, December 17, 2018 8:20 AM > To: Daly, Lee ; akhil.goyal@nxp.com > Cc: dev@dpdk.org; Daly, Lee > Subject: RE: [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum > support in driver >=20 > Hi Lee, >=20 > Apologies if the logic is already done for my query >=20 > snipped > > + /* Set private xform checksum */ > > + switch (xform->compress.chksum) { > > + /* Raw deflate by default */ > Does the user have to choose RTE_COMP_CHECKSUM_NONE while creating > compress/isal instance? At the moment, yes the application must fill out the xform/instance.=20 >=20 > > + case(RTE_COMP_CHECKSUM_NONE): > > + priv_xform->compress.chksum =3D IGZIP_DEFLATE; > > + break; > > + case(RTE_COMP_CHECKSUM_CRC32): > > + priv_xform->compress.chksum =3D > IGZIP_GZIP_NO_HDR; > > + break; > > + case(RTE_COMP_CHECKSUM_ADLER32): > > + priv_xform->compress.chksum =3D > IGZIP_ZLIB_NO_HDR; > > + break; > > + case(RTE_COMP_CHECKSUM_CRC32_ADLER32): > > + ISAL_PMD_LOG(ERR, "Combined CRC and ADLER > > checksum not" > > + " supported\n"); > > + return -ENOTSUP; > > + default: > > + ISAL_PMD_LOG(ERR, "Checksum type not > > supported\n"); > > + return -ENOTSUP; > Do we not fall back to RTE_COMP_CHECKSUM_NONE if the configuration is > wrong and report warning? >=20 Right now, the xform must be filled out correctly before compression can be= executed.=20 Perhaps we could do as you say and fall back to a default config if the non= -essential params are incorrect. > snipped