From: "Daly, Lee" <lee.daly@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Trahe, Fiona" <fiona.trahe@intel.com>
Subject: Re: [dpdk-dev] [PATCH] compress/isal: fix use after free
Date: Tue, 21 May 2019 15:07:30 +0000 [thread overview]
Message-ID: <F5C6929789601049BEB7272E26735598915E12@IRSMSX106.ger.corp.intel.com> (raw)
In-Reply-To: <20190521144713.12046-1-stephen@networkplumber.org>
Hi Stephen,
Thanks for the patch.
> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Tuesday, May 21, 2019 3:47 PM
> To: Daly, Lee <lee.daly@intel.com>
> Cc: dev@dpdk.org; Stephen Hemminger <stephen@networkplumber.org>
> Subject: [PATCH] compress/isal: fix use after free
>
> The release function was using qp->stream after already releasing it and the
> null pointer checking was missing.
>
> Also since rte_free(NULL) is a no-op, remove unnecessary checks for NULL.
>
> Coverity issure: 340860
> Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression functionality")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/compress/isal/isal_compress_pmd_ops.c | 14 ++++----------
> 1 file changed, 4 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c
Acked-by: Lee Daly <lee.daly@intel.com>
next prev parent reply other threads:[~2019-05-21 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 14:47 Stephen Hemminger
2019-05-21 15:07 ` Daly, Lee [this message]
2019-05-27 16:00 ` Trahe, Fiona
2019-06-19 14:54 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F5C6929789601049BEB7272E26735598915E12@IRSMSX106.ger.corp.intel.com \
--to=lee.daly@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).