From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id B2D09376D for ; Mon, 24 Oct 2016 04:21:10 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP; 23 Oct 2016 19:21:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,539,1473145200"; d="scan'208";a="893142680" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 23 Oct 2016 19:21:09 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 23 Oct 2016 19:21:09 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 23 Oct 2016 19:21:08 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.104]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.96]) with mapi id 14.03.0248.002; Mon, 24 Oct 2016 10:21:05 +0800 From: "Yang, Qiming" To: "Yigit, Ferruh" , "dev@dpdk.org" CC: "Wu, Jingjing" , "Zhang, Helin" Thread-Topic: [dpdk-dev] [PATCH 1/2] net/i40e: fix link status change interrupt Thread-Index: AQHSJRiIHxl2vCoY90qNyjMn1JanUaCvHreAgAfQMMA= Date: Mon, 24 Oct 2016 02:21:04 +0000 Message-ID: References: <1476338840-50003-1-git-send-email-qiming.yang@intel.com> <2eed66c7-14df-9950-bd92-cecafc8267f0@intel.com> In-Reply-To: <2eed66c7-14df-9950-bd92-cecafc8267f0@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWZlYmNhNmEtYTFlZi00NjYyLThlZTctZjhkODJlMjI1Njk1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImJcL1lNWThzMHNBRWkzWXUwYlVINXpvNFNpWFBTTXJiVElLaTNUNGpiZUVFPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix link status change interrupt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Oct 2016 02:21:11 -0000 Ferruh, Thank you for your reminder, I will remember to CC to the maintainer in fut= ure.=20 Jingjing and Helin, Can you help to review these two patches? Thanks, Qiming -----Original Message----- From: Yigit, Ferruh=20 Sent: Wednesday, October 19, 2016 6:57 PM To: Yang, Qiming ; dev@dpdk.org Cc: Wu, Jingjing Subject: Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix link status change interr= upt Hi Qiming, On 10/13/2016 7:07 AM, Qiming Yang wrote: > Previously, link status interrupt in i40e is achieved by checking=20 > LINK_STAT_CHANGE_MASK in PFINT_ICR0 register which is provided only=20 > for diagnostic use. Instead, drivers need to get the link status=20 > change notification by using LSE (Link Status Event). >=20 > This patch enables LSE and calls LSC callback when the event is=20 > received. This patch also removes the processing on=20 > LINK_STAT_CHANGE_MASK. >=20 > Fixes: 5c9222058df7 ("i40e: move to drivers/net/") >=20 > Signed-off-by: Qiming Yang CC: Jingjing Wu Can you please add maintainer(s) to CC when sending a patch, mail traffic i= n dpdk.org is keep increasing and it is hard to follow. Adding maintainer t= o the CC helps a lot to the maintainer. I guess everybody knows, but just as a reminder, maintainer list kept in file: http://dpdk.org/browse/dpdk/tree/MAINTAINERS Thanks, ferruh