From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 1C706558A for ; Fri, 18 Nov 2016 03:11:01 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP; 17 Nov 2016 18:11:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,655,1473145200"; d="scan'208";a="192810285" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 17 Nov 2016 18:11:00 -0800 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 17 Nov 2016 18:11:00 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 17 Nov 2016 18:11:00 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.239]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.142]) with mapi id 14.03.0248.002; Fri, 18 Nov 2016 10:10:58 +0800 From: "Yang, Qiming" To: Thomas Monjalon CC: "dev@dpdk.org" , "Horton, Remy" , "Wu, Jingjing" , "Chen, Jing D" Thread-Topic: [dpdk-dev] [PATCH 1/5] ethdev: add firmware version get Thread-Index: AQHSQLeFtvh9SR5HJESmiBvPOQIviqDcp7SAgAFUlXA= Date: Fri, 18 Nov 2016 02:10:57 +0000 Message-ID: References: <1479375779-46629-1-git-send-email-qiming.yang@intel.com> <1479375779-46629-2-git-send-email-qiming.yang@intel.com> <1520754.cvFYjLZGdK@xps13> In-Reply-To: <1520754.cvFYjLZGdK@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTM1N2QyMzctMTE5MC00NDQ2LWExY2QtYzY2MmE3ZmQxN2E3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlJiaUx1djIwSEt1Ukk4MkhxQ1drcTdXN1FSYnpLYkFoS1RCbnVFMlJPMGs9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/5] ethdev: add firmware version get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2016 02:11:02 -0000 Hi, Thomas -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20 Sent: Thursday, November 17, 2016 9:37 PM To: Yang, Qiming Cc: dev@dpdk.org; Horton, Remy ; Wu, Jingjing ; Chen, Jing D Subject: Re: [dpdk-dev] [PATCH 1/5] ethdev: add firmware version get 2016-11-17 17:42, Qiming Yang: > This patch added API for 'rte_eth_dev_fwver_get' >=20 > void rte_eth_dev_fwver_get(uint8_t port_id, char *fw_version, int=20 > fw_length); Copying some code here doesn't help really help. Could you describe what we can expect in this string? How can we compare this version number across different devices of the same= driver? How does it apply to FPGA devices? What is the potential use? Qiming: I'll add more describes in the next version. [...] > /** > + * Retrieve the firmware version of an Ethernet device. We should stop talking about Ethernet device. Networking device is more appropriate. And in this case, "device" is enough. Qiming: Got it. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param fw_version > + * A pointer the firmware version of an Ethernet device > + * @param fw_length > + * The size of the firmware version, which should be large enough to s= tore > + * the firmware version of the device. How do we know that the length is too small? Qiming: The length is a number large enough to store the firmware version. = Original I use a fixed number 20, but in order to be more flexible, I repla= ce it into a variable.=20 > + */ > +void rte_eth_dev_fwver_get(uint8_t port_id, char *fw_version, int=20 > +fw_length); Why not returning some errors? Qiming: It's a good advice. You forgot to remove the deprecation notice in this patch. PS: the series is broken as some patches are not numbered and this one is n= ot the first one. Please use a cover-letter to introduce such series. Qiming: It's my fault. Thank you for your reminder, I will pay attention ne= xt time.