From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 8D7FE2BB9 for ; Thu, 5 Jan 2017 02:50:56 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP; 04 Jan 2017 17:50:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,318,1477983600"; d="scan'208";a="1090056940" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 04 Jan 2017 17:50:55 -0800 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 4 Jan 2017 17:50:54 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 4 Jan 2017 17:50:54 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.177]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0248.002; Thu, 5 Jan 2017 09:50:45 +0800 From: "Yang, Qiming" To: "Yigit, Ferruh" , "dev@dpdk.org" CC: "Zhang, Helin" , "Horton, Remy" Thread-Topic: [PATCH v4 2/5] net/e1000: add firmware version get Thread-Index: AQHSZoNywNHZi+XI10yOj7amZW/oLKEn0oAAgAFMiAA= Date: Thu, 5 Jan 2017 01:50:44 +0000 Message-ID: References: <1482841816-54143-1-git-send-email-qiming.yang@intel.com> <1483531428-14481-1-git-send-email-qiming.yang@intel.com> <1483531428-14481-3-git-send-email-qiming.yang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzBhMTU3MmItZjFiNi00YjNkLTgzMjEtMTc2MWQ2MDFjZDM4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InZvc3FzUngxV0M4RzBDWmtsVXdUMzFjZTF0ZXJmVkE5WU9ValwvUXg3WGUwPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 2/5] net/e1000: add firmware version get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jan 2017 01:50:57 -0000 -----Original Message----- From: Yigit, Ferruh=20 Sent: Wednesday, January 4, 2017 10:00 PM To: Yang, Qiming ; dev@dpdk.org Cc: Zhang, Helin ; Horton, Remy Subject: Re: [PATCH v4 2/5] net/e1000: add firmware version get On 1/4/2017 12:03 PM, Qiming Yang wrote: > This patch adds a new function eth_igb_fw_version_get. >=20 > Signed-off-by: Qiming Yang > --- <...> > =20 > static void > +eth_igb_fw_version_get(struct rte_eth_dev *dev, u32 *fw_major, u32 *fw_m= inor, > + u32 *fw_patch, u32 *etrack_id) > +{ <...> > + default: > + /* if option rom is valid, display its version too*/ > + if (fw.or_valid) { > + *fw_major =3D fw.eep_major; > + *fw_minor =3D fw.eep_minor; > + *etrack_id =3D fw.etrack_id; > + *fw_patch =3D fw.or_patch; > + /* no option rom */ > + } else { > + if (fw.etrack_id !=3D 0X0000) { > + *fw_major =3D fw.eep_major; > + *fw_minor =3D fw.eep_minor; > + *etrack_id =3D fw.etrack_id; indentation is wrong here. Also it looks like major, minor assignment is co= mmon and can be moved from if statement. Qiming: will correct them > + } else { > + *fw_major =3D fw.eep_major; > + *fw_minor =3D fw.eep_minor; > + } > + } > + break; > + } > +} <...>