From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 0BA38282 for ; Sun, 8 Jan 2017 04:09:49 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP; 07 Jan 2017 19:09:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,333,1477983600"; d="scan'208";a="210829236" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 07 Jan 2017 19:09:48 -0800 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sat, 7 Jan 2017 19:09:48 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sat, 7 Jan 2017 19:09:48 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.177]) by SHSMSX103.ccr.corp.intel.com ([10.239.4.69]) with mapi id 14.03.0248.002; Sun, 8 Jan 2017 11:09:46 +0800 From: "Yang, Qiming" To: Thomas Monjalon CC: "dev@dpdk.org" , "Yigit, Ferruh" , "Zhang, Helin" , "Horton, Remy" Thread-Topic: [dpdk-dev] [PATCH v4 1/5] ethdev: add firmware version get Thread-Index: AQHSZoNzMVCNJOXNnEi4lBrhRPDvAaEpYKkAgASLPrA= Date: Sun, 8 Jan 2017 03:09:46 +0000 Message-ID: References: <1482841816-54143-1-git-send-email-qiming.yang@intel.com> <1483531428-14481-1-git-send-email-qiming.yang@intel.com> <1483531428-14481-2-git-send-email-qiming.yang@intel.com> <2775891.n5HL0JQtYk@xps13> In-Reply-To: <2775891.n5HL0JQtYk@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWE5MzJhNDQtYmFiNC00NzZjLWI4YTQtMmE3NGQ2NTcxODM1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImY4aWFaWUZ1UUd0VkdDN1N2WjJSNlIzSW5UY0RZaEpPR1RTUXNoSEpHdkk9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/5] ethdev: add firmware version get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jan 2017 03:09:50 -0000 -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20 Sent: Thursday, January 5, 2017 9:45 PM To: Yang, Qiming Cc: dev@dpdk.org; Yigit, Ferruh ; Zhang, Helin ; Horton, Remy Subject: Re: [dpdk-dev] [PATCH v4 1/5] ethdev: add firmware version get 2017-01-04 20:03, Qiming Yang: > This patch adds a new API 'rte_eth_dev_fw_version_get' for fetching=20 > firmware version related information by a given device. [...] > /** > + * Retrieve the firmware version of a device. > + * > + * @param port_id > + * The port identifier of the device. > + * @param fw_major > + * A pointer to store the major firmware version of a device. > + * @param fw_minor > + * A pointer to store the minor firmware version of a device. > + * @param fw_patch > + * A pointer to store the firmware patch number of a device. > + * @param etrack_id > + * A pointer to store the nvm version of a device. > + */ > +void rte_eth_dev_fw_version_get(uint8_t port_id, uint32_t *fw_major, > + uint32_t *fw_minor, uint32_t *fw_patch, uint32_t *etrack_id); After reading few comments, I think it should just fill a string. There is no way the firmware version can be generalized or standardized. If the application wants to do some processing like number comparisons, it = has to be aware of the specific firmware version string format. If you want to help the application to parse this string, it should be a PM= D specific API. Qiming: I agree with you.