From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 4193F2E8A for ; Sat, 14 Jan 2017 04:06:07 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 13 Jan 2017 19:06:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,225,1477983600"; d="scan'208";a="30291708" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 13 Jan 2017 19:06:06 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 13 Jan 2017 19:06:06 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 13 Jan 2017 19:06:05 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.177]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.132]) with mapi id 14.03.0248.002; Sat, 14 Jan 2017 11:06:04 +0800 From: "Yang, Qiming" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "Lu, Wenzhuo" Thread-Topic: [dpdk-dev] [PATCH v5] app/testpmd: supported offload capabilities query Thread-Index: AQHSbXkYala3FvGgG0OAeZ42OlH6YqE2JoqA//+rYoCAAXgzgA== Date: Sat, 14 Jan 2017 03:06:03 +0000 Message-ID: References: <1482485513-7087-1-git-send-email-qiming.yang@intel.com> <1484191582-17293-1-git-send-email-qiming.yang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzE5Yjc1OWYtNWM1My00NzlmLWEwYjctODY3OTg3OTYyYzEwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImNRTnRFUTZBa2hReGN5SUxVYVV2ZDBMZnRiYm5YcTNFU1VKaWRmTXVVMU09In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5] app/testpmd: supported offload capabilities query X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jan 2017 03:06:08 -0000 HI, Pablo > ... >=20 > > + > > + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_TCP_CKSUM) { > > + printf("RX TCP checksum: "); > > + if (dev->data->dev_conf.rxmode.hw_ip_checksum) > > + printf("on\n"); > > + else > > + printf("off\n"); > > + } > > + > > + if (dev_info.rx_offload_capa & > > DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM) > > + printf("RX Outer IPv4 checksum: "); >=20 > Missing on/off? > Qiming: I didn't find any switch for this feature in DPDK now. I'll=20 > fix the format problem. Thank you. I just saw your v6. So, what does this mean? If the device is capable of do= ing this, but there is no way to enable/disable it, it would mean that it w= ill be enabled or disabled by default, right? I see that X550 NIC is the only one capable of this. Maybe Wenzhuo can help= on clarifying this. I would say that, if it is enabled when it is capable, then you should prin= t "on", But printing only "RX Outer IPv4 checksum" does not give any inform= ation (when all the rest of the capabilities show on/off). Qiming: Ok, I'll check with Wenzhuo, Thank you for your advice for the unsu= itable print in this place . Thanks, Pablo =20