From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A281E11D4 for ; Mon, 13 Feb 2017 11:09:18 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2017 02:09:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,156,1484035200"; d="scan'208";a="820263278" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 13 Feb 2017 02:09:17 -0800 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 13 Feb 2017 02:09:17 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 13 Feb 2017 02:09:17 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.177]) by SHSMSX103.ccr.corp.intel.com ([10.239.4.69]) with mapi id 14.03.0248.002; Mon, 13 Feb 2017 18:09:15 +0800 From: "Yang, Qiming" To: "Yigit, Ferruh" , "dev@dpdk.org" CC: "Wu, Jingjing" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: fix vlan insert code redundance Thread-Index: AQHSgz3E68LiCT6C00OG7cyKacUmgqFhg2GAgACU+pCABJPp8A== Date: Mon, 13 Feb 2017 10:09:14 +0000 Message-ID: References: <1486689994-37746-1-git-send-email-qiming.yang@intel.com> <0425f979-8198-4cc8-f70b-f1c9a037fd7f@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2Y2OGYyY2QtOTBkNi00MGFjLWFkZTMtNjNmMDU5MGIwZDlmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlJsSjQwRUJOTk03S3htSkNSWFFtcUY2V2Q5RklhRzBwVHpCMFZUZ2JlUkE9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: [dpdk-dev] FW: [PATCH] net/i40e: fix vlan insert code redundance X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Feb 2017 10:09:19 -0000 Hi, Ferruh > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yang, Qiming > Sent: Friday, February 10, 2017 7:21 PM > To: Yigit, Ferruh ; dev@dpdk.org > Cc: Wu, Jingjing > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix vlan insert code redundance >=20 > > On 2/10/2017 1:26 AM, Qiming Yang wrote: > > > This patch removed useless tx_flags in vlan insertion. > > > > Overall this looks good, I wonder what was the initial intention of > > this code, understanding it helps to figure out if there is a hidden de= fect. >=20 > Thank you for your remind. I'll investigate it. I have aligned with Helin (he contribute these code), and make sure these c= ode is useless, these code is left by history. >=20 > > > > This code not fixes a defect, but improves the code, is there any > > performance gain with this? >=20 > I'll do more test and give you a feedback. According to my test, this code will not bring any obvious performance gain= , and no lose also. And as you said this is not a bug fix, should I remove the fix line and mod= ify the commit log? >=20 > > If not, I am for deferring this to next release. > > > > > > > > Fixes: 4861cde46116 ("i40e: new poll mode driver") > > > > > > Signed-off-by: Qiming Yang > > > ---