From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id A16FC1B161 for ; Thu, 14 Sep 2017 03:23:13 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP; 13 Sep 2017 18:23:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,390,1500966000"; d="scan'208";a="151088631" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 13 Sep 2017 18:23:11 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 13 Sep 2017 18:23:09 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 13 Sep 2017 18:23:08 -0700 Received: from shsmsx151.ccr.corp.intel.com ([169.254.3.98]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.219]) with mapi id 14.03.0319.002; Thu, 14 Sep 2017 09:23:02 +0800 From: "Yang, Qiming" To: Shijith Thotton , Gregory Etelson CC: "dev@dpdk.org" , "Tan, Jianfeng" , "Yigit, Ferruh" Thread-Topic: vf init issue with patch igb_uio: issue FLR during open and release of device file Thread-Index: AdMsY+cDtYlICV1TTJyXdLDau5GdIP//rc+A//6F2OA= Date: Thu, 14 Sep 2017 01:23:01 +0000 Message-ID: References: <20170913104840.GA14229@localhost.localdomain> In-Reply-To: <20170913104840.GA14229@localhost.localdomain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTFkYWY3ZDgtZTM1MC00MjllLWE1NWItNDBjMGFmODA2YmQzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjBSakFkcFpZTUhzMDVobk41MW5GUWc5QTQ2dUJuWXk0UkJBeDZnQUNiVlk9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open and release of device file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Sep 2017 01:23:14 -0000 > -----Original Message----- > From: Shijith Thotton [mailto:shijith.thotton@caviumnetworks.com] > Sent: Wednesday, September 13, 2017 6:49 PM > To: Yang, Qiming ; Gregory Etelson > > Cc: dev@dpdk.org; Tan, Jianfeng ; Yigit, Ferruh > > Subject: Re: vf init issue with patch igb_uio: issue FLR during open and = release of > device file >=20 > On Wed, Sep 13, 2017 at 07:51:30AM +0000, Yang, Qiming wrote: > > Hi, Shijith > > > > > > > > VF init error will happen after apply your patch, error log as below= . If > > revert your commit, all things work well. And this issue is not only= occur > > in i40 VF but also ixgbe. > > > > Could you help to check it soon? > > > > > > > > [root@localhost app]# ./testpmd -c 7 -n 4 -- -i > > > > EAL: Detected 10 lcore(s) > > > > EAL: No free hugepages reported in hugepages-1048576kB > > > > EAL: Probing VFIO support... > > > > EAL: WARNING: cpu flags constant_tsc=3Dyes nonstop_tsc=3Dno -> using > > unreliable clock cycles ! > > > > EAL: PCI device 0000:00:03.0 on NUMA socket -1 > > > > EAL: Invalid NUMA socket, default to 0 > > > > EAL: probe driver: 8086:154c net_i40e_vf > > > > i40evf_init_vf(): init_adminq failed: -53 > > > > i40evf_dev_init(): Init vf failed > > > > EAL: Requested device 0000:00:03.0 cannot be used > > > > > > > > commit b58eedfc7dd57eef6d12e2c654a52c834f36084a > > Author: Shijith Thotton > > Date: Fri Jul 7 16:43:51 2017 +0530 > > > > igb_uio: issue FLR during open and release of device file > > > > Set UIO info device file operations open and release. Call pci reset > > function inside open and release to clear device state at start and = end. > > Copied this behaviour from vfio_pci kernel module code. With this pa= tch, > > it is not mandatory to issue FLR by PMD's during init and close. > > > > Bus master enable and disable are added in open and release respecti= vely > > to take care of device DMA. > > > > Signed-off-by: Shijith Thotton > > Reviewed-by: Jianfeng Tan > > Acked-by: Ferruh Yigit > > Acked-by: Gregory Etelson > > > > > > > > Best Regard, > > > > Yang Qiming > > > > >=20 > Hi Yang Qiming, >=20 > We didn't face this issue while preparing patch. I think, Gregory tested = it for Intel > NICs. Adding more people to the loop for help. >=20 > Shijith Thanks a lot, Shijith Qiming