From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 2414E7CCD; Fri, 22 Sep 2017 04:48:06 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Sep 2017 19:48:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,426,1500966000"; d="scan'208";a="314907206" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 21 Sep 2017 19:48:04 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 21 Sep 2017 19:48:02 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.159]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.152]) with mapi id 14.03.0319.002; Fri, 22 Sep 2017 10:47:36 +0800 From: "Yang, Qiming" To: Shijith Thotton , "dev@dpdk.org" CC: "Yigit, Ferruh" , Thomas Monjalon , "Patil, Harish" , "Zhang, Helin" , Gregory Etelson , "Tan, Jianfeng" , "Hu, Xuekun" , "Li, Xiaoyun" , "Thotton, Shijith" , "stable@dpdk.org" Thread-Topic: [PATCH] igb_uio: remove PCI reset during uio device open Thread-Index: AQHTMTGZcOwTcp04sEeGKizi7iPLv6LANmfQ Date: Fri, 22 Sep 2017 02:47:35 +0000 Message-ID: References: <1505816653-28715-1-git-send-email-shijith.thotton@caviumnetworks.com> In-Reply-To: <1505816653-28715-1-git-send-email-shijith.thotton@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWNiMzgyNmQtZmQ4Mi00NjljLThkMDktOTlkOTJmOWY0YTIxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkhTYVlLVXFQU3JWUkNlRUZvNmhqV2l6VWNnQ3RVd1RmNGJVQ0NORDEzOVk9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] igb_uio: remove PCI reset during uio device open X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Sep 2017 02:48:07 -0000 > -----Original Message----- > From: Shijith Thotton [mailto:shijith.thotton@caviumnetworks.com] > Sent: Tuesday, September 19, 2017 6:24 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Thomas Monjalon > ; Yang, Qiming ; Patil, Haris= h > ; Zhang, Helin ; Gregory > Etelson ; Tan, Jianfeng ; Hu, > Xuekun ; Li, Xiaoyun ; Thotton= , > Shijith ; stable@dpdk.org > Subject: [PATCH] igb_uio: remove PCI reset during uio device open >=20 > Issuing reset during uio device open caused PMD init failure for some NIC= VFs > (i40, ixgbe, qede) in host. So this initial reset is removed. > Bus master enable is kept as part of open since we disable it in uio devi= ce release. >=20 > Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of devic= e file") > Cc: stable@dpdk.org >=20 > Signed-off-by: Shijith Thotton > --- > lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > index 07a19a3..a6c2996 100644 > --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > @@ -179,9 +179,7 @@ struct rte_uio_pci_dev { > struct rte_uio_pci_dev *udev =3D info->priv; > struct pci_dev *dev =3D udev->pdev; >=20 > - pci_reset_function(dev); > - > - /* set bus master, which was cleared by the reset function */ > + /* enable bus mastering on the device */ > pci_set_master(dev); >=20 > return 0; > -- > 1.8.3.1 Tested-by: Qiming Yang Hi, applied and tested this patch with 17.08 DPDK VF and 2.1.26 kernel PF and it fixes the problem on 10G/25G/40G.