From: "Yang, Qiming" <qiming.yang@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Shahaf Shuler <shahafs@mellanox.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [DPDK] lib/librte_ether: add comments RSS flags
Date: Wed, 10 Jan 2018 02:15:16 +0000 [thread overview]
Message-ID: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F8232E4@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1569196.tzFYU9QD0F@xps>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, January 8, 2018 4:33 AM
> To: Yang, Qiming <qiming.yang@intel.com>
> Cc: Shahaf Shuler <shahafs@mellanox.com>; Andrew Rybchenko
> <arybchenko@solarflare.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [DPDK] lib/librte_ether: add comments RSS flags
>
> 07/01/2018 07:32, Shahaf Shuler:
> > Saturday, January 6, 2018 12:22 PM, Andrew Rybchenko:
> >
> > [..]
> >
> > > > #define ETH_RSS_PORT (1ULL << RTE_ETH_FLOW_PORT)
> > > > +/** Enable RSS offload on VXLAN packets */
> > > > #define ETH_RSS_VXLAN (1ULL << RTE_ETH_FLOW_VXLAN)
> > > > +/** Enable RSS offload on GENEVE packets */
> > > > #define ETH_RSS_GENEVE (1ULL << RTE_ETH_FLOW_GENEVE)
> > > > +/** Enable RSS offload on NVGRE packets */
> > > > #define ETH_RSS_NVGRE (1ULL << RTE_ETH_FLOW_NVGRE)
> > > >
> > > > #define ETH_RSS_IP ( \
> > >
> > > These comments just decode the define name and not that useful. What
> > > would be really useful here is specification of which fields of the
> > > packet headers are used to calculate hash especially in the case of tunnels.
> >
> > +1.
> >
> > Also maybe some more clarifications, for example:
> > 1. What is the expected behavior when, for example, setting the
> ETH_RSS_IPV6_EX and regular IPv6 packet arrives? is RSS apply on it?
> > 2. What is the expected behavior from the PMD when not supporting one of
> the RSS types?
> > For example most of the DPDK examples uses ETH_RSS_IP [1], however
> very few devices actually supports each and every RSS type.
> > Assuming such configuration returns with no error, what should application
> expect when unsupported packet type arrives.
> >
> > #define ETH_RSS_IP ( \
> > ETH_RSS_IPV4 | \
> > ETH_RSS_FRAG_IPV4 | \
> > ETH_RSS_NONFRAG_IPV4_OTHER | \
> > ETH_RSS_IPV6 | \
> > ETH_RSS_FRAG_IPV6 | \
> > ETH_RSS_NONFRAG_IPV6_OTHER | \
> > ETH_RSS_IPV6_EX)
>
> +1
> We really need a detailed documentation of the.
>
I agree with your comments, but the same RSS configuration may have different behavior(RSS offload and input set) in different driver. Adding driver specific information in rte_ethdev.h is not suitable.
So I think the best scheme is to update driver's document to detail the exact behavior and add reference doc here.
> It must be at least as detailed as lib/librte_mbuf/rte_mbuf_ptype.h.
> Thanks
next prev parent reply other threads:[~2018-01-10 2:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 18:15 Qiming Yang
2018-01-06 10:21 ` Andrew Rybchenko
2018-01-07 6:32 ` Shahaf Shuler
2018-01-07 20:32 ` Thomas Monjalon
2018-01-10 2:15 ` Yang, Qiming [this message]
2018-01-10 7:38 ` Thomas Monjalon
2018-01-10 7:55 ` Andrew Rybchenko
2018-01-09 3:20 ` Yang, Qiming
2018-01-09 3:21 ` Yang, Qiming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F8232E4@SHSMSX101.ccr.corp.intel.com \
--to=qiming.yang@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).