DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Yang, Qiming" <qiming.yang@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Dai, Wei" <wei.dai@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] net/ixgbe: fix VFIO interrupt mapping in PF
Date: Wed, 10 Jan 2018 06:28:56 +0000	[thread overview]
Message-ID: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F82355A@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1515486230-77436-1-git-send-email-wenzhuo.lu@intel.com>

+1 why we disable interrupt in dev_start twice?

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> Sent: Tuesday, January 9, 2018 4:24 PM
> To: Dai, Wei <wei.dai@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] net/ixgbe: fix VFIO interrupt mapping in PF
> 
> Hi Wei,
> 
> > +	rte_intr_disable(intr_handle);
> TBH, confused by this patch. I see the intr already disabled at the begining of this
> function, ixgbe_dev_start, why we need to disable it again?

  reply	other threads:[~2018-01-10  6:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-20  8:11 [dpdk-dev] [PATCH] " Wei Dai
2017-09-20 10:24 ` Wei Dai
2018-01-09  8:23   ` [dpdk-dev] " Wenzhuo Lu
2018-01-10  6:28     ` Yang, Qiming [this message]
2018-01-22  7:03       ` Dai, Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F82355A@SHSMSX101.ccr.corp.intel.com \
    --to=qiming.yang@intel.com \
    --cc=dev@dpdk.org \
    --cc=wei.dai@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).