From: "Yang, Qiming" <qiming.yang@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix dcb configuration issue
Date: Fri, 18 May 2018 01:26:19 +0000 [thread overview]
Message-ID: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F8BE7E4@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E70611531B406F@SHSMSX103.ccr.corp.intel.com>
I'll send v2 later.
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Thursday, May 17, 2018 9:19 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; Yang, Qiming <qiming.yang@intel.com>;
> stable@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: fix dcb configuration issue
>
> Hi Qiming
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org]
> > Sent: Thursday, May 17, 2018 9:23 PM
> > To: dev@dpdk.org
> > Cc: Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo
> > <wenzhuo.lu@intel.com>; Yang, Qiming <qiming.yang@intel.com>;
> > stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH] net/ixgbe: fix dcb configuration issue
> >
> > This patch removed unnecessary check in ixgbe_check_mq_mode, fixed
> > historical issue.
> >
> > Fixes: 27b609cbd1c6 ("ethdev: move the multi-queue mode check to
> > specific
> > drivers")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> > ---
> > drivers/net/ixgbe/ixgbe_ethdev.c | 37
> > -------------------------------------
> > 1 file changed, 37 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index f5006bc..9e3ae95 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -2300,43 +2300,6 @@ ixgbe_check_mq_mode(struct rte_eth_dev *dev)
> > }
> > }
> >
> > - /* For DCB mode check our configuration before we go further
> */
> > - if (dev_conf->rxmode.mq_mode == ETH_MQ_RX_DCB) {
> > - const struct rte_eth_dcb_rx_conf *conf;
> > -
> > - if (nb_rx_q != IXGBE_DCB_NB_QUEUES) {
> > - PMD_INIT_LOG(ERR, "DCB selected,
> nb_rx_q != %d.",
> > - IXGBE_DCB_NB_QUEUES);
> > - return -EINVAL;
> > - }
> > - conf = &dev_conf->rx_adv_conf.dcb_rx_conf;
> > - if (!(conf->nb_tcs == ETH_4_TCS ||
> > - conf->nb_tcs == ETH_8_TCS)) {
>
> I guess, we should not remove all check, for nb_tcs, it still valid, right?
>
> > - PMD_INIT_LOG(ERR, "DCB selected,
> nb_tcs != %d"
> > - " and nb_tcs != %d.",
> > - ETH_4_TCS, ETH_8_TCS);
> > - return -EINVAL;
> > - }
> > - }
> > -
> > - if (dev_conf->txmode.mq_mode == ETH_MQ_TX_DCB) {
> > - const struct rte_eth_dcb_tx_conf *conf;
> > -
> > - if (nb_tx_q != IXGBE_DCB_NB_QUEUES) {
> > - PMD_INIT_LOG(ERR, "DCB, nb_tx_q != %d.",
> > - IXGBE_DCB_NB_QUEUES);
> > - return -EINVAL;
> > - }
> > - conf = &dev_conf->tx_adv_conf.dcb_tx_conf;
> > - if (!(conf->nb_tcs == ETH_4_TCS ||
> > - conf->nb_tcs == ETH_8_TCS)) {
> Same to rx.
> > - PMD_INIT_LOG(ERR, "DCB selected,
> nb_tcs != %d"
> > - " and nb_tcs != %d.",
> > - ETH_4_TCS, ETH_8_TCS);
> > - return -EINVAL;
> > - }
> > - }
> > -
> > /*
> > * When DCB/VT is off, maximum number of queues changes,
> > * except for 82598EB, which remains constant.
> > --
> > 2.9.5
next prev parent reply other threads:[~2018-05-18 1:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 13:22 Qiming Yang
2018-05-17 13:18 ` Zhang, Qi Z
2018-05-18 1:26 ` Yang, Qiming [this message]
2018-05-18 4:25 ` Wu, Jingjing
2018-05-18 9:51 ` [dpdk-dev] [PATCH v2] " Qiming Yang
2018-05-18 3:16 ` Lu, Wenzhuo
2018-05-18 14:33 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F8BE7E4@SHSMSX101.ccr.corp.intel.com \
--to=qiming.yang@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).