From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2155A00E6 for ; Wed, 10 Jul 2019 09:27:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AB1561D9E; Wed, 10 Jul 2019 09:27:44 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id BA299A3; Wed, 10 Jul 2019 09:27:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2019 00:27:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,473,1557212400"; d="scan'208";a="176755218" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 10 Jul 2019 00:27:40 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jul 2019 00:27:40 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 10 Jul 2019 00:27:40 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 10 Jul 2019 00:27:40 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.134]) by shsmsx102.ccr.corp.intel.com ([169.254.2.3]) with mapi id 14.03.0439.000; Wed, 10 Jul 2019 15:27:38 +0800 From: "Yang, Qiming" To: "Zhang, Qi Z" , "Lu, Wenzhuo" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v3 1/2] net/ice: remove unused devargs Thread-Index: AQHVNtXwZD8khBC58EKa2TB9swpxo6bDdAOA Date: Wed, 10 Jul 2019 07:27:38 +0000 Message-ID: References: <20190710041630.47927-1-qi.z.zhang@intel.com> In-Reply-To: <20190710041630.47927-1-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/ice: remove unused devargs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- From: Zhang, Qi Z=20 Sent: Wednesday, July 10, 2019 12:16 PM To: Yang, Qiming ; Lu, Wenzhuo Cc: dev@dpdk.org; Zhang, Qi Z ; stable@dpdk.org Subject: [PATCH v3 1/2] net/ice: remove unused devargs Remove devarg "max_queue_pair_num" related code since it is not complete im= plemented. Fixes: f9cf4f864150 ("net/ice: support device initialization") Cc: stable@dpdk.org Signed-off-by: Qi Zhang --- doc/guides/nics/ice.rst | 8 ------ drivers/net/ice/ice_ethdev.c | 66 ++--------------------------------------= ---- 2 files changed, 3 insertions(+), 71 deletions(-) diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index 666b1b= 272..e9b3a48bc 100644 --- a/doc/guides/nics/ice.rst +++ b/doc/guides/nics/ice.rst @@ -49,14 +49,6 @@ Please note that enabling debugging options may affect s= ystem performance. Runtime Config Options ~~~~~~~~~~~~~~~~~~~~~~ =20 -- ``Maximum Number of Queue Pairs`` - - The maximum number of queue pairs is decided by HW. If not configured, A= PP - uses the number from HW. Users can check the number by calling the API - ``rte_eth_dev_info_get``. - If users want to limit the number of queues, they can set a smaller numb= er - using EAL parameter like ``max_queue_pair_num=3Dn``. - =20 Driver compilation and testing ------------------------------ diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c in= dex 9ce730cd4..4b5cd8269 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -17,7 +17,6 @@ #include "ice_rxtx.h" #include "ice_switch_filter.h" =20 -#define ICE_MAX_QP_NUM "max_queue_pair_num" #define ICE_DFLT_OUTER_TAG_TYPE ICE_AQ_VSI_OUTER_TAG_VLAN_9100 #define IC= E_DFLT_PKG_FILE "/lib/firmware/intel/ice/ddp/ice.pkg" =20 @@ -251,59 +250,6 @@ ice_init_controlq_parameter(struct ice_hw *hw) } =20 static int -ice_check_qp_num(const char *key, const char *qp_value, - __rte_unused void *opaque) -{ - char *end =3D NULL; - int num =3D 0; - - while (isblank(*qp_value)) - qp_value++; - - num =3D strtoul(qp_value, &end, 10); - - if (!num || (*end =3D=3D '-') || errno) { - PMD_DRV_LOG(WARNING, "invalid value:\"%s\" for key:\"%s\", " - "value must be > 0", - qp_value, key); - return -1; - } - - return num; -} - -static int -ice_config_max_queue_pair_num(struct rte_devargs *devargs) -{ - struct rte_kvargs *kvlist; - const char *queue_num_key =3D ICE_MAX_QP_NUM; - int ret; - - if (!devargs) - return 0; - - kvlist =3D rte_kvargs_parse(devargs->args, NULL); - if (!kvlist) - return 0; - - if (!rte_kvargs_count(kvlist, queue_num_key)) { - rte_kvargs_free(kvlist); - return 0; - } - - if (rte_kvargs_process(kvlist, queue_num_key, - ice_check_qp_num, NULL) < 0) { - rte_kvargs_free(kvlist); - return 0; - } - ret =3D rte_kvargs_process(kvlist, queue_num_key, - ice_check_qp_num, NULL); - rte_kvargs_free(kvlist); - - return ret; -} - -static int ice_res_pool_init(struct ice_res_pool_info *pool, uint32_t base, uint32_t num) { @@ -1128,13 +1074,9 @@ ice_pf_sw_init(struct rte_eth_dev *dev) struct ice_pf *pf =3D ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private); struct ice_hw *hw =3D ICE_PF_TO_HW(pf); =20 - if (ice_config_max_queue_pair_num(dev->device->devargs) > 0) - pf->lan_nb_qp_max =3D - ice_config_max_queue_pair_num(dev->device->devargs); - else - pf->lan_nb_qp_max =3D - (uint16_t)RTE_MIN(hw->func_caps.common_cap.num_txq, - hw->func_caps.common_cap.num_rxq); + pf->lan_nb_qp_max =3D + (uint16_t)RTE_MIN(hw->func_caps.common_cap.num_txq, + hw->func_caps.common_cap.num_rxq); =20 pf->lan_nb_qps =3D pf->lan_nb_qp_max; =20 @@ -3751,8 +3693,6 @@ static struct rte_pci_driver rte_ice_pmd =3D { RTE_P= MD_REGISTER_PCI(net_ice, rte_ice_pmd); RTE_PMD_REGISTER_PCI_TABLE(net_ice,= pci_id_ice_map); RTE_PMD_REGISTER_KMOD_DEP(net_ice, "* igb_uio | uio_pci_= generic | vfio-pci"); -RTE_PMD_REGISTER_PARAM_STRING(net_ice, - ICE_MAX_QP_NUM "=3D"); =20 RTE_INIT(ice_init_log) { -- 2.13.6 Acked-by: Qiming Yang