From: "Yang, Qiming" <qiming.yang@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ice: fixed wrong return value
Date: Thu, 11 Jul 2019 02:58:23 +0000 [thread overview]
Message-ID: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF17A503D15@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <2036459.gTkXSRM7NQ@xps>
Hi, Thomas
Thanks for the comments. Will change it.
Qiming
-----Original Message-----
From: Thomas Monjalon [mailto:thomas@monjalon.net]
Sent: Wednesday, July 10, 2019 3:30 PM
To: Yang, Qiming <qiming.yang@intel.com>
Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ice: fixed wrong return value
Hi,
09/07/2019 06:08, Qiming Yang:
> Fixed error return value check and wrong error message.
>
> Fixes: d76116a4678f ("net/ice: add generic flow API")
>
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
Comments about the formatting of the title:
The verb must be in infinitive form: "fix".
The title must say which behaviour is fixed, not the code detail (we don't care in the title if it because of a return value or variable assignment).
Here it is about fixing flow rule validation, right?
One more thing, the word "wrong" can always be avoided after "fix", because we know you are not fixing something which worked perfectly :)
Do not hesitate to share these tips around you.
Thank you
next prev parent reply other threads:[~2019-07-11 2:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 4:08 Qiming Yang
2019-07-10 7:29 ` Thomas Monjalon
2019-07-11 2:58 ` Yang, Qiming [this message]
2019-07-15 2:23 ` [dpdk-dev] [PATCH v3] net/ice: fix flow validation fail Qiming Yang
2019-07-15 3:19 ` Xing, Beilei
2019-07-15 5:59 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F5DF4F0E3AFEF648ADC1C3C33AD4DBF17A503D15@SHSMSX101.ccr.corp.intel.com \
--to=qiming.yang@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).