From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30259A00E6 for ; Thu, 11 Jul 2019 04:58:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CC9072E81; Thu, 11 Jul 2019 04:58:29 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id D02D02C6A for ; Thu, 11 Jul 2019 04:58:27 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2019 19:58:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,476,1557212400"; d="scan'208";a="341251228" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 10 Jul 2019 19:58:26 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jul 2019 19:58:26 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jul 2019 19:58:26 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.134]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.55]) with mapi id 14.03.0439.000; Thu, 11 Jul 2019 10:58:24 +0800 From: "Yang, Qiming" To: Thomas Monjalon CC: "dev@dpdk.org" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH] net/ice: fixed wrong return value Thread-Index: AQHVNgxkpSQUN3y3s0eN5rBQxMMobabC8FYAgAHMaUA= Date: Thu, 11 Jul 2019 02:58:23 +0000 Message-ID: References: <20190709040812.4191-1-qiming.yang@intel.com> <2036459.gTkXSRM7NQ@xps> In-Reply-To: <2036459.gTkXSRM7NQ@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ice: fixed wrong return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Thomas Thanks for the comments. Will change it. Qiming -----Original Message----- From: Thomas Monjalon [mailto:thomas@monjalon.net]=20 Sent: Wednesday, July 10, 2019 3:30 PM To: Yang, Qiming Cc: dev@dpdk.org; Yigit, Ferruh Subject: Re: [dpdk-dev] [PATCH] net/ice: fixed wrong return value Hi, 09/07/2019 06:08, Qiming Yang: > Fixed error return value check and wrong error message. >=20 > Fixes: d76116a4678f ("net/ice: add generic flow API") >=20 > Signed-off-by: Qiming Yang Comments about the formatting of the title: The verb must be in infinitive form: "fix". The title must say which behaviour is fixed, not the code detail (we don't = care in the title if it because of a return value or variable assignment). Here it is about fixing flow rule validation, right? One more thing, the word "wrong" can always be avoided after "fix", because= we know you are not fixing something which worked perfectly :) Do not hesitate to share these tips around you. Thank you