DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Yang, Qiming" <qiming.yang@intel.com>
To: "Jiang, JunyuX" <junyux.jiang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>,
	 "Ye, Xiaolong" <xiaolong.ye@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix Rx/Tx queue interrupt for X552/557 device
Date: Thu, 5 Sep 2019 06:56:53 +0000	[thread overview]
Message-ID: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF17A539781@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20190904033147.55297-1-junyux.jiang@intel.com>

> -----Original Message-----
> From: Jiang, JunyuX
> Sent: Wednesday, September 4, 2019 11:32 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; Jiang, JunyuX <junyux.jiang@intel.com>;
> stable@dpdk.org
> Subject: [PATCH v4] net/ixgbe: fix Rx/Tx queue interrupt for X552/557 device
> 
> Interrupt mode is not working on X552/557 device because this device
> doesn't enable the queue interrupt mapping, this patch fixed the issue.
> 
> Fixes: d2e72774e58c ("ixgbe/base: support X550")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jiang JunyuX <junyux.jiang@intel.com>
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 03fc1f717..e36e1c58e 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -5896,7 +5896,8 @@ ixgbe_set_ivar_map(struct ixgbe_hw *hw, int8_t
> direction,
>  		IXGBE_WRITE_REG(hw, IXGBE_IVAR(idx), tmp);
>  	} else if ((hw->mac.type == ixgbe_mac_82599EB) ||
>  			(hw->mac.type == ixgbe_mac_X540) ||
> -			(hw->mac.type == ixgbe_mac_X550)) {
> +			(hw->mac.type == ixgbe_mac_X550) ||
> +			(hw->mac.type == ixgbe_mac_X550EM_x)) {
>  		if (direction == -1) {
>  			/* other causes */
>  			idx = ((queue & 1) * 8);
> @@ -6026,6 +6027,7 @@ ixgbe_configure_msix(struct rte_eth_dev *dev)
>  		case ixgbe_mac_82599EB:
>  		case ixgbe_mac_X540:
>  		case ixgbe_mac_X550:
> +		case ixgbe_mac_X550EM_x:
>  			ixgbe_set_ivar_map(hw, -1, 1, IXGBE_MISC_VEC_ID);
>  			break;
>  		default:
> --
> 2.17.1

Acked-by: Qiming Yang <qiming.yang@intel.com>

  reply	other threads:[~2019-09-05  6:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-27  4:07 [dpdk-dev] [PATCH] net/ixgbe: fix Rx/Tx queue interrupt for X552/557 devices junyux.jiang
2019-08-27  5:44 ` Yang, Qiming
2019-08-27  6:57 ` [dpdk-dev] [PATCH v2] " Jiang JunyuX
2019-08-27  8:07   ` Ye Xiaolong
2019-08-27 11:12     ` Jiang, JunyuX
2019-09-02  2:29   ` [dpdk-dev] [PATCH v3] " Jiang JunyuX
2019-09-04  3:31     ` [dpdk-dev] [PATCH v4] net/ixgbe: fix Rx/Tx queue interrupt for X552/557 device Jiang JunyuX
2019-09-05  6:56       ` Yang, Qiming [this message]
2019-09-05  8:26       ` Ye Xiaolong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F5DF4F0E3AFEF648ADC1C3C33AD4DBF17A539781@SHSMSX101.ccr.corp.intel.com \
    --to=qiming.yang@intel.com \
    --cc=dev@dpdk.org \
    --cc=junyux.jiang@intel.com \
    --cc=stable@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).