DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Yang, Qiming" <qiming.yang@intel.com>
To: "Jiang, JunyuX" <junyux.jiang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Li, Xiaoyun" <xiaoyun.li@intel.com>,
	"Jiang, JunyuX" <junyux.jiang@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] examples/vmdq: fix the output of pools/queues
Date: Mon, 2 Mar 2020 02:35:03 +0000	[thread overview]
Message-ID: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF17A601C67@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20200226083525.68649-1-junyux.jiang@intel.com>



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Junyu Jiang
> Sent: Wednesday, February 26, 2020 16:35
> To: dev@dpdk.org
> Cc: Li, Xiaoyun <xiaoyun.li@intel.com>; Jiang, JunyuX
> <junyux.jiang@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] examples/vmdq: fix the output of
> pools/queues
> 
> To match the pools/queues configuration, the pools/queues output should
> start from VMDQ base queue. This patch fixed the issue.
> 
> Fixes: 6bb97df521aa ("examples/vmdq: new app")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
> ---
>  examples/vmdq/main.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/examples/vmdq/main.c b/examples/vmdq/main.c index
> 011110920..dcba3a708 100644
> --- a/examples/vmdq/main.c
> +++ b/examples/vmdq/main.c
> @@ -441,10 +441,11 @@ update_mac_address(struct rte_mbuf *m,
> unsigned dst_port)  static void  sighup_handler(int signum)  {
> -	unsigned q;
> -	for (q = 0; q < num_queues; q++) {
> -		if (q % (num_queues/num_pools) == 0)
> -			printf("\nPool %u: ", q/(num_queues/num_pools));
> +	unsigned int q = vmdq_queue_base;
> +	for (; q < num_queues; q++) {
> +		if (q % (num_vmdq_queues / num_pools) == 0)

What's the different between num_vmdq_queues and num_queues?

> +			printf("\nPool %u: ", (q - vmdq_queue_base) /
> +			       (num_vmdq_queues / num_pools));
>  		printf("%lu ", rxPackets[q]);
>  	}
>  	printf("\nFinished handling signal %d\n", signum);
> --
> 2.17.1


  reply	other threads:[~2020-03-02  2:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26  7:57 [dpdk-dev] [PATCH] " Junyu Jiang
2020-02-26  8:35 ` [dpdk-dev] [PATCH v2] " Junyu Jiang
2020-03-02  2:35   ` Yang, Qiming [this message]
2020-03-02  3:10   ` Li, Xiaoyun
2020-03-02  6:41   ` [dpdk-dev] [PATCH v3] " Junyu Jiang
2020-03-02  7:19     ` Li, Xiaoyun
2020-03-30  2:21       ` [dpdk-dev] [dpdk-stable] " Han, YingyaX
2020-03-31 14:35         ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F5DF4F0E3AFEF648ADC1C3C33AD4DBF17A601C67@SHSMSX101.ccr.corp.intel.com \
    --to=qiming.yang@intel.com \
    --cc=dev@dpdk.org \
    --cc=junyux.jiang@intel.com \
    --cc=stable@dpdk.org \
    --cc=xiaoyun.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).