From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C62A75A6F for ; Tue, 20 Jan 2015 04:01:49 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 19 Jan 2015 19:01:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,431,1418112000"; d="scan'208";a="653493646" Received: from kmsmsx153.gar.corp.intel.com ([172.21.73.88]) by fmsmga001.fm.intel.com with ESMTP; 19 Jan 2015 19:01:47 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by KMSMSX153.gar.corp.intel.com (172.21.73.88) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 20 Jan 2015 11:01:46 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.64]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.92]) with mapi id 14.03.0195.001; Tue, 20 Jan 2015 11:01:45 +0800 From: "Wang, Zhihong" To: Neil Horman Thread-Topic: [dpdk-dev] [PATCH 0/4] DPDK memcpy optimization Thread-Index: AQHQM+g93pBJjc9asEOmHYpPzg55ApzITFZA Date: Tue, 20 Jan 2015 03:01:44 +0000 Message-ID: References: <1421632414-10027-1-git-send-email-zhihong.wang@intel.com> <20150119130221.GB21790@hmsreliant.think-freely.org> In-Reply-To: <20150119130221.GB21790@hmsreliant.think-freely.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 0/4] DPDK memcpy optimization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jan 2015 03:01:50 -0000 > -----Original Message----- > From: Neil Horman [mailto:nhorman@tuxdriver.com] > Sent: Monday, January 19, 2015 9:02 PM > To: Wang, Zhihong > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/4] DPDK memcpy optimization >=20 > On Mon, Jan 19, 2015 at 09:53:30AM +0800, zhihong.wang@intel.com wrote: > > This patch set optimizes memcpy for DPDK for both SSE and AVX platforms= . > > It also extends memcpy test coverage with unaligned cases and more test > points. > > > > Optimization techniques are summarized below: > > > > 1. Utilize full cache bandwidth > > > > 2. Enforce aligned stores > > > > 3. Apply load address alignment based on architecture features > > > > 4. Make load/store address available as early as possible > > > > 5. General optimization techniques like inlining, branch reducing, > > prefetch pattern access > > > > Zhihong Wang (4): > > Disabled VTA for memcpy test in app/test/Makefile > > Removed unnecessary test cases in test_memcpy.c > > Extended test coverage in test_memcpy_perf.c > > Optimized memcpy in arch/x86/rte_memcpy.h for both SSE and AVX > > platforms > > > > app/test/Makefile | 6 + > > app/test/test_memcpy.c | 52 +- > > app/test/test_memcpy_perf.c | 238 +++++--- > > .../common/include/arch/x86/rte_memcpy.h | 664 > +++++++++++++++------ > > 4 files changed, 656 insertions(+), 304 deletions(-) > > > > -- > > 1.9.3 > > > > > Are you able to compile this with gcc 4.9.2? The compilation of > test_memcpy_perf is taking forever for me. It appears hung. > Neil Neil, Thanks for reporting this! It should compile but will take quite some time if the CPU doesn't support = AVX2, the reason is that: 1. The SSE & AVX memcpy implementation is more complicated than AVX2 versio= n thus the compiler takes more time to compile and optimize 2. The new test_memcpy_perf.c contains 126 constants memcpy calls for bette= r test case coverage, that's quite a lot I've just tested this patch on an Ivy Bridge machine with GCC 4.9.2: 1. The whole compile process takes 9'41" with the original test_memcpy_perf= .c (63 + 63 =3D 126 constant memcpy calls) 2. It takes only 2'41" after I reduce the constant memcpy call number to 12= + 12 =3D 24 I'll reduce memcpy call in the next version of patch. Zhihong (John)