From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from p02c12o144.mxlogic.net (p02c12o144.mxlogic.net [208.65.145.77]) by dpdk.org (Postfix) with ESMTP id 158C880AF for ; Fri, 10 Oct 2014 21:54:30 +0200 (CEST) Received: from unknown [66.151.187.11] (EHLO smtp.sonusnet.com) by p02c12o144.mxlogic.net(mxl_mta-8.1.0-0) over TLS secured channel with ESMTP id 33b38345.0.47218.00-177.136115.p02c12o144.mxlogic.net (envelope-from ); Fri, 10 Oct 2014 14:01:59 -0600 (MDT) X-MXL-Hash: 54383b3765f99aad-6449c0e29c6096c49a24f25365149d9456931e9c Received: from INBA-HUB01.sonusnet.com (10.70.51.86) by psmwsonshc01.sonusnet.com (10.176.20.27) with Microsoft SMTP Server (TLS) id 14.3.158.1; Fri, 10 Oct 2014 16:01:53 -0400 Received: from INBA-MAIL02.sonusnet.com ([10.70.51.89]) by inba-hub01.sonusnet.com ([fe80::5cbc:2823:f6cc:9ce7%11]) with mapi id 14.03.0181.006; Sat, 11 Oct 2014 01:31:51 +0530 From: Karmarkar Suyash To: "dev@dpdk.org" Thread-Topic: Bug in outgoing packet with vmxnet3 with VLAN tagging Thread-Index: Ac/kh+KBhIm2UllpT42l44ZaAfJORQAOxRAw Date: Fri, 10 Oct 2014 20:01:50 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.54.20] MIME-Version: 1.0 X-AnalysisOut: [v=2.1 cv=C/f9yG/+ c=1 sm=1 tr=0 a=uJKQf5YWhIR+nybujYFUDg==] X-AnalysisOut: [:117 a=uJKQf5YWhIR+nybujYFUDg==:17 a=URNJFqk9g_oA:10 a=xvT] X-AnalysisOut: [xkHHju24A:10 a=BLceEmwcHowA:10 a=xqWC_Br6kY4A:10 a=kUVcWBO] X-AnalysisOut: [SAAAA:8 a=YlVTAMxIAAAA:8 a=8rWy6zfcAAAA:8 a=_m3BHOSDn2WbIe] X-AnalysisOut: [IeyYYA:9 a=FosEW0f-p7N81cY5:21 a=_Z57-G0ifzDfOy5i:21 a=Cju] X-AnalysisOut: [IK1q_8ugA:10 a=SumTzdpxxCEA:10 a=yMhMjlubAAAA:8 a=SSmOFEAC] X-AnalysisOut: [AAAA:8 a=rmHlcvIngmY97BAZwWIA:9 a=xLry4BPaP70Yi9Bj:21 a=gK] X-AnalysisOut: [O2Hq4RSVkA:10 a=UiCQ7L4-1S4A:10 a=hTZeC7Yk6K0A:10 a=frz4Au] X-AnalysisOut: [Cg-hUA:10] X-Spam: [F=0.5000000000; CM=0.500; MH=0.500(2014101025); S=0.200(2014051901)] X-MAIL-FROM: X-SOURCE-IP: [66.151.187.11] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] Bug in outgoing packet with vmxnet3 with VLAN tagging X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Oct 2014 19:54:32 -0000 I meant in the below code snippet the function must be corrected to - ******************************** <<< file 1: /DPDK/DPDK-1.6.0/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c/1 >>> file 2: /DPDK/DPDK-1.6.0/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c ******************************** -----[289 changed to 289-290]----- < if(txm->pkt.data_len = > (hw->cur_mtu + ETHER_HDR_LEN)) { --- > //if(txm->pkt.data_le= n > (hw->cur_mtu + ETHER_HDR_LEN)) { > if(txm->pkt.data_len = > (hw->cur_mtu + ETHER_HDR_LEN + 4 /* 4 bytes for VLAN */)) { From: Karmarkar Suyash Sent: Friday, October 10, 2014 6:17 PM To: 'dev@dpdk.org' Subject: Bug in outgoing packet with vmxnet3 with VLAN tagging Hello All, When a outgoing packet is sent with data Len more than 1514 which will be a= case in VLAN (Max 1518 ) the packet is getting dropped because of the belo= w code snippet. This looks incorrect as in case of VLAN . FUNCTION NAME: vmxnet3_xmit_pkts /* Needs to minus ether header len */ if(txm->pkt.data_len > (hw-= >cur_mtu + ETHER_HDR_LEN)) { PMD_TX_LOG(= DEBUG, "Packet data_len higher than MTU\n"); rte_pktmbuf= _free(tx_pkts[nb_tx]); txq->stats.= drop_total++; nb_tx++; continue; } #define ETHER_ADDR_LEN 6 /**< Length of Ethernet address. */ #define ETHER_TYPE_LEN 2 /**< Length of Ethernet type field. */ #define ETHER_CRC_LEN 4 /**< Length of Ethernet CRC. */ #define ETHER_HDR_LEN \ (ETHER_ADDR_LEN * 2 + ETHER_TYPE_LEN) /**< Length of Ethernet h= eader. */ But in case of VLAN the Ethernet header is 18 bytes. Does this mean we do n= ot support VLAN for VMXNET3 PMD? Thanks. Regards Suyash Karmarkar