From: "Kozak, KubaX" <kubax.kozak@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Jain, Deepak K" <deepak.k.jain@intel.com>,
"Jastrzebski, MichalX K" <michalx.k.jastrzebski@intel.com>,
"Piasecki, JacekX" <jacekx.piasecki@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5 2/5] cfgfile: change existing API functions
Date: Thu, 21 Sep 2017 09:12:22 +0000 [thread overview]
Message-ID: <F6B2DFED41632040B39446096019FF8E010BC2DB@hasmsx107.ger.corp.intel.com> (raw)
In-Reply-To: <5053892.oD5KOMONjY@xps>
Hi Thomas,
Yes we can wait to 18.02. I'll prepare v6 patchset without these changes.
Best regards,
Kuba
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Tuesday, September 19, 2017 23:27
> To: Kozak, KubaX <kubax.kozak@intel.com>
> Cc: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>; Jain, Deepak K
> <deepak.k.jain@intel.com>; Jastrzebski, MichalX K <michalx.k.jastrzebski@intel.com>; Piasecki,
> JacekX <jacekx.piasecki@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v5 2/5] cfgfile: change existing API functions
>
> Hi,
>
> 19/09/2017 13:07, Kuba Kozak:
> > @@ -409,7 +407,11 @@ rte_cfgfile_section_num_entries(struct
> > rte_cfgfile *cfg, {
> > const struct rte_cfgfile_section *s = _get_section(cfg, sectionname);
> > if (s == NULL)
> > +#ifdef RTE_NEXT_ABI
> > + return -EINVAL;
> > +#else
> > return -1;
> > +#endif
> > return s->num_entries;
> > }
>
> Why are you using RTE_NEXT_ABI?
> Can you wait 18.02 to make this change?
>
> Anyway, when breaking the API you need to update tha API section of the release notes.
>
> > @@ -219,7 +219,7 @@ int
> > rte_cfgfile_section_num_entries_by_index(struct rte_cfgfile *cfg,
> > * @param max_entries
> > * Maximum number of section entries to be stored in entries array
> > * @return
> > -* Number of entries populated on success, -1 otherwise
> > +* Number of entries populated on success, -EINVAL otherwise
> > */
>
> This documentation become wrong if RTE_NEXT_ABI is disabled.
prev parent reply other threads:[~2017-09-21 9:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 11:07 Kuba Kozak
2017-09-19 21:26 ` Thomas Monjalon
2017-09-21 9:12 ` Kozak, KubaX [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F6B2DFED41632040B39446096019FF8E010BC2DB@hasmsx107.ger.corp.intel.com \
--to=kubax.kozak@intel.com \
--cc=bruce.richardson@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=jacekx.piasecki@intel.com \
--cc=michalx.k.jastrzebski@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).