From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 7B46E1B18C for ; Thu, 21 Sep 2017 11:12:28 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP; 21 Sep 2017 02:12:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,424,1500966000"; d="scan'208";a="314580972" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 21 Sep 2017 02:12:26 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 21 Sep 2017 02:12:26 -0700 Received: from lcsmsx154.ger.corp.intel.com (10.186.165.229) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 21 Sep 2017 02:12:26 -0700 Received: from hasmsx107.ger.corp.intel.com ([169.254.2.222]) by LCSMSX154.ger.corp.intel.com ([169.254.7.81]) with mapi id 14.03.0319.002; Thu, 21 Sep 2017 12:12:23 +0300 From: "Kozak, KubaX" To: Thomas Monjalon CC: "dev@dpdk.org" , "Richardson, Bruce" , "Jain, Deepak K" , "Jastrzebski, MichalX K" , "Piasecki, JacekX" Thread-Topic: [dpdk-dev] [PATCH v5 2/5] cfgfile: change existing API functions Thread-Index: AQHTMTgnhSI5FJQNS0qItEv8z3G7H6K8h0IAgAKI8nA= Date: Thu, 21 Sep 2017 09:12:22 +0000 Message-ID: References: <1505819248-19792-1-git-send-email-kubax.kozak@intel.com> <5053892.oD5KOMONjY@xps> In-Reply-To: <5053892.oD5KOMONjY@xps> Accept-Language: pl-PL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.103.102.51] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 2/5] cfgfile: change existing API functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2017 09:12:28 -0000 Hi Thomas, Yes we can wait to 18.02. I'll prepare v6 patchset without these changes. Best regards, Kuba > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, September 19, 2017 23:27 > To: Kozak, KubaX > Cc: dev@dpdk.org; Richardson, Bruce ; Jain, D= eepak K > ; Jastrzebski, MichalX K ; Piasecki, > JacekX > Subject: Re: [dpdk-dev] [PATCH v5 2/5] cfgfile: change existing API funct= ions >=20 > Hi, >=20 > 19/09/2017 13:07, Kuba Kozak: > > @@ -409,7 +407,11 @@ rte_cfgfile_section_num_entries(struct > > rte_cfgfile *cfg, { > > const struct rte_cfgfile_section *s =3D _get_section(cfg, sectionname= ); > > if (s =3D=3D NULL) > > +#ifdef RTE_NEXT_ABI > > + return -EINVAL; > > +#else > > return -1; > > +#endif > > return s->num_entries; > > } >=20 > Why are you using RTE_NEXT_ABI? > Can you wait 18.02 to make this change? >=20 > Anyway, when breaking the API you need to update tha API section of the r= elease notes. >=20 > > @@ -219,7 +219,7 @@ int > > rte_cfgfile_section_num_entries_by_index(struct rte_cfgfile *cfg, > > * @param max_entries > > * Maximum number of section entries to be stored in entries array > > * @return > > -* Number of entries populated on success, -1 otherwise > > +* Number of entries populated on success, -EINVAL otherwise > > */ >=20 > This documentation become wrong if RTE_NEXT_ABI is disabled.