From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id A6C261B1B5; Wed, 11 Oct 2017 08:58:09 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP; 10 Oct 2017 23:58:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,360,1503385200"; d="scan'208";a="908793162" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 10 Oct 2017 23:58:07 -0700 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 10 Oct 2017 23:58:07 -0700 Received: from HASMSX110.ger.corp.intel.com (10.184.198.28) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 10 Oct 2017 23:58:07 -0700 Received: from hasmsx106.ger.corp.intel.com ([169.254.10.144]) by HASMSX110.ger.corp.intel.com ([169.254.6.210]) with mapi id 14.03.0319.002; Wed, 11 Oct 2017 09:58:04 +0300 From: "Kozak, KubaX" To: "Yang, Zhiyong" , "Ananyev, Konstantin" CC: "dev@dpdk.org" , "stable@dpdk.org" , "Jastrzebski, MichalX K" Thread-Topic: [dpdk-dev] [PATCH] l3fwd-acl: fix unchecked return value Thread-Index: AQHTPD4ooAMpqlk+EUmi4n0x2pWX8aLcftyAgAHENjA= Date: Wed, 11 Oct 2017 06:58:04 +0000 Message-ID: References: <1507031282-12469-1-git-send-email-kubax.kozak@intel.com> In-Reply-To: Accept-Language: pl-PL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.103.102.68] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] l3fwd-acl: fix unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Oct 2017 06:58:10 -0000 Thanks Zhiyong, Should I correct this patch and resend to dpdk or is it just a suggestion f= or future? Regards, Kuba >-----Original Message----- >From: Yang, Zhiyong >Sent: Tuesday, October 10, 2017 08:56 >To: Kozak, KubaX ; Ananyev, Konstantin >Cc: dev@dpdk.org; Kozak, KubaX ; stable@dpdk.org >Subject: RE: [dpdk-dev] [PATCH] l3fwd-acl: fix unchecked return value > >Hi=1B$B!$=1B(Bkubax, > >When you form the patch , you should add v2 and changes in v2. >Besides that, please be free to add >Acked-by: zhiyong yang > >Thanks >Zhiyong > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Kuba Kozak >> Sent: Tuesday, October 3, 2017 7:48 PM >> To: Ananyev, Konstantin >> Cc: dev@dpdk.org; Kozak, KubaX ; stable@dpdk.org >> Subject: [dpdk-dev] [PATCH] l3fwd-acl: fix unchecked return value >> >> Add return value check and error handling for fseek call. >> >> Coverity issue: 143435 >> Fixes: 361b2e9559fc ("acl: new sample l3fwd-acl") >> Cc: konstantin.ananyev@intel.com >> Cc: stable@dpdk.org >> >> Signed-off-by: Kuba Kozak >> Acked-by: Konstantin Ananyev >> ---