From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 16AF58047 for ; Mon, 8 Dec 2014 15:54:29 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 08 Dec 2014 06:52:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,538,1413270000"; d="scan'208";a="650308561" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga002.jf.intel.com with ESMTP; 08 Dec 2014 06:54:15 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.93]) by IRSMSX152.ger.corp.intel.com ([169.254.6.56]) with mapi id 14.03.0195.001; Mon, 8 Dec 2014 14:54:09 +0000 From: "Wodkowski, PawelX" To: "Doherty, Declan" , "dev@dpdk.org" Thread-Topic: [PATCH v2] bond: fix for mac assignment to slaves device Thread-Index: AQHQEtjzNENyEulbS0mTxPJvSB2VS5yFxkjA Date: Mon, 8 Dec 2014 14:54:08 +0000 Message-ID: References: <1417800885-18643-1-git-send-email-declan.doherty@intel.com> <1418037572-6546-1-git-send-email-declan.doherty@intel.com> In-Reply-To: <1418037572-6546-1-git-send-email-declan.doherty@intel.com> Accept-Language: pl-PL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] bond: fix for mac assignment to slaves device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Dec 2014 14:54:30 -0000 > -----Original Message----- > From: Doherty, Declan > Sent: Monday, December 08, 2014 12:20 PM > To: dev@dpdk.org > Cc: Wodkowski, PawelX; Jiajia, SunX; Doherty, Declan > Subject: [PATCH v2] bond: fix for mac assignment to slaves device >=20 > -V2: > Tidies up the slave_remove function as per Pawel's comments. >=20 > Adding call to mac_address_slaves_update from the lsc handler when the > first slave become active to propagate any mac changes made while > devices are inactive >=20 > Changed removing slave logic to use memmove instead of memcpy to move > data within the same array, as this was corrupting the slave array. >=20 > Adding unit test to cover failing assignment scenarios >=20 > Signed-off-by: Declan Doherty Acked-by: Wodkowski, Pawel