From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B7EA858F7 for ; Fri, 16 Jan 2015 10:40:25 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 16 Jan 2015 01:40:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,409,1418112000"; d="scan'208";a="638243712" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga001.jf.intel.com with ESMTP; 16 Jan 2015 01:40:23 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.28]) by IRSMSX109.ger.corp.intel.com ([169.254.13.11]) with mapi id 14.03.0195.001; Fri, 16 Jan 2015 09:40:04 +0000 From: "Wodkowski, PawelX" To: Thomas Monjalon , "Jastrzebski, MichalX K" Thread-Topic: [dpdk-dev] [PATCH] ethdev: fix missing parenthesis Thread-Index: AQHQLB3IvTw3YTzN3U2Q0XX3YCLKQJzBMpeAgAFTORA= Date: Fri, 16 Jan 2015 09:40:05 +0000 Message-ID: References: <1420815925-7988-1-git-send-email-michalx.k.jastrzebski@intel.com> <29007273.jolbkK9tis@xps13> In-Reply-To: <29007273.jolbkK9tis@xps13> Accept-Language: pl-PL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] ethdev: fix missing parenthesis X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jan 2015 09:40:26 -0000 > Good catch! > Was introduced in commit 4bdefaade6d1 (VMDQ enhancements). > Note that quite often, when a patch contains too much things, > we miss this kind of bugs. That's a reason to well split patches. >=20 What is most surprising I did not spotted this, neither the compiler what I think it should. It was my IDE which pointed possible bug. Are we using '-Wparentheses' switch? If not, we should consider to use this switch? Pawel